Bug 218140 - Web Inspector: URL breakpoints should also pause when HTML attributes that trigger loads are set
Summary: Web Inspector: URL breakpoints should also pause when HTML attributes that tr...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-10-23 15:28 PDT by Devin Rousso
Modified: 2022-09-14 12:47 PDT (History)
6 users (show)

See Also:

Attachments
[Patch] WIP (15.19 KB, patch)
2020-10-23 22:26 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
[Patch] WIP (15.08 KB, patch)
2020-10-23 22:33 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2020-10-23 15:28:31 PDT 
Right now, URL breakpoints are limited to XHR and fetch.  They should really include anything that can trigger network activity (but realistically we only care about situations where that trigger is some JavaScript code).

```
let image = new Image;
image.src = "foo.png"; // should be able to pause here
```
Comment 1 Devin Rousso 2020-10-23 15:28:49 PDT 
<rdar://problem/70636814>
Comment 2 Devin Rousso 2020-10-23 22:26:37 PDT 
Created attachment 412231 [details]
[Patch] WIP

first attempt that uses the same instrumentation point as `Network` to pause whenever a request is sent
Comment 3 Devin Rousso 2020-10-23 22:33:11 PDT 
Created attachment 412233 [details]
[Patch] WIP

rebase
Comment 4 EWS Watchlist 2020-10-23 22:34:58 PDT 
This patch modifies the inspector protocol. Please ensure that any frontend changes appropriately use feature checks for new protocol features.
Comment 5 BJ Burg 2020-10-26 16:54:46 PDT 
Comment on attachment 412233 [details]
[Patch] WIP

LGTM so far, looks like the tests need some fixing.
Comment 6 Devin Rousso 2022-09-11 13:28:36 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/4239
Comment 7 EWS 2022-09-14 12:47:28 PDT 
Committed 254488@main (7ad0216f7c41): <https://commits.webkit.org/254488@main>

Reviewed commits have been landed. Closing PR #4239 and removing active labels.