Bug 218049 - [webkitpy] Use webkitcorepy's autoinstaller for beautifulsoup
Summary: [webkitpy] Use webkitcorepy's autoinstaller for beautifulsoup
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-10-21 13:23 PDT by Jonathan Bedard
Modified: 2020-10-21 16:26 PDT (History)
6 users (show)

See Also:

Attachments
Patch (6.66 KB, patch)
2020-10-21 13:26 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2020-10-21 13:23:55 PDT 
Part of removing webkitpy's autoinstaller in favor of webkitcorepy's.
Comment 1 Radar WebKit Bug Importer 2020-10-21 13:24:18 PDT 
<rdar://problem/70542684>
Comment 2 Jonathan Bedard 2020-10-21 13:26:57 PDT 
Created attachment 412023 [details]
Patch
Comment 3 Aakash Jain 2020-10-21 14:54:19 PDT 
Comment on attachment 412023 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=412023&action=review

> Tools/Scripts/webkitpy/thirdparty/__init__.py:-111
> -    def _install_pytest(self):

is this pytest removal intentional?
Comment 4 Jonathan Bedard 2020-10-21 16:12:01 PDT 
(In reply to Aakash Jain from comment #3)
> Comment on attachment 412023 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=412023&action=review
> 
> > Tools/Scripts/webkitpy/thirdparty/__init__.py:-111
> > -    def _install_pytest(self):
> 
> is this pytest removal intentional?

Yes! We removed the auto installer for pytest a few weeks back, forgot to delete the function.
Comment 5 EWS 2020-10-21 16:26:13 PDT 
Committed r268844: <https://trac.webkit.org/changeset/268844>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 412023 [details].