Bug 217995 - Share more code between WorkerGlobalScope and WorkletGlobalScope
Summary: Share more code between WorkerGlobalScope and WorkletGlobalScope
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Audio (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on: 217980
Blocks: 217724 217058 218051
  Show dependency tree / graph
 
Reported: 2020-10-20 15:41 PDT by Chris Dumez
Modified: 2020-10-21 14:16 PDT (History)
11 users (show)

See Also:

Attachments
Patch (37.19 KB, patch)
2020-10-20 17:11 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2020-10-20 15:41:05 PDT 
Share more code between WorkerGlobalScope and WorkletGlobalScope.
Comment 1 Chris Dumez 2020-10-20 17:11:12 PDT 
Created attachment 411941 [details]
Patch
Comment 2 Chris Dumez 2020-10-21 13:56:49 PDT 
Ping review?
Comment 3 Darin Adler 2020-10-21 14:01:15 PDT 
Comment on attachment 411941 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411941&action=review

> Source/WebCore/workers/WorkerOrWorkletGlobalScope.h:57
> +    virtual void prepareForDestruction();

protected?
Comment 4 Chris Dumez 2020-10-21 14:05:01 PDT 
Comment on attachment 411941 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411941&action=review

> Source/WebCore/Modules/webaudio/AudioWorkletThread.cpp:90
> +            workletGlobalScope.prepareForDestruction();

See here.

>> Source/WebCore/workers/WorkerOrWorkletGlobalScope.h:57
>> +    virtual void prepareForDestruction();
> 
> protected?

No, I don't think we can because it is called from WorkerThread / AudioWorkletThread.
Comment 5 EWS 2020-10-21 14:15:54 PDT 
Committed r268822: <https://trac.webkit.org/changeset/268822>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 411941 [details].
Comment 6 Radar WebKit Bug Importer 2020-10-21 14:16:38 PDT 
<rdar://problem/70544800>