Bug 217957 - TestOptionsGeneratedKeys.h:30:52: warning: backslash-newline at end of file
Summary: TestOptionsGeneratedKeys.h:30:52: warning: backslash-newline at end of file
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: PC Linux
: P2 Normal
Assignee: Michael Catanzaro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-10-20 08:13 PDT by Michael Catanzaro
Modified: 2020-10-20 10:07 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.50 KB, patch)
2020-10-20 08:15 PDT, Michael Catanzaro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2020-10-20 08:13:27 PDT 
[5187/5225] Building CXX object Tools/...WebKitTestRunner.dir/TestOptions.cpp.o
In file included from ../../Tools/WebKitTestRunner/TestOptions.cpp:29:
DerivedSources/WebKitTestRunner/TestOptionsGeneratedKeys.h:30:52: warning: backslash-newline at end of file
   30 | #define GENERATED_WEB_PREFERENCE_KEY_TYPE_MAPPINGS \
      |

I guess this is bad because something else from another header could be on the next line, depending on the order that headers get included into the source file.
Comment 1 Michael Catanzaro 2020-10-20 08:15:19 PDT 
Created attachment 411866 [details]
Patch
Comment 2 Sam Weinig 2020-10-20 09:24:55 PDT 
Thanks.
Comment 3 EWS 2020-10-20 10:06:02 PDT 
Committed r268740: <https://trac.webkit.org/changeset/268740>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 411866 [details].
Comment 4 Radar WebKit Bug Importer 2020-10-20 10:07:35 PDT 
<rdar://problem/70489878>