Bug 217914 - [ews] use -o while unzipping layout-test-results.zip
Summary: [ews] use -o while unzipping layout-test-results.zip
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks: 175056
  Show dependency tree / graph
 
Reported: 2020-10-19 11:26 PDT by Aakash Jain
Modified: 2021-02-08 07:37 PST (History)
5 users (show)

See Also:

Attachments
Patch (3.36 KB, patch)
2020-10-19 11:41 PDT, Aakash Jain 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2020-10-19 11:26:03 PDT 
We should use -o flag while unzipping layout-test-results.zip in EWS to improve unzip performance.
Comment 1 Aakash Jain 2020-10-19 11:41:51 PDT 
Created attachment 411767 [details]
Patch
Comment 2 Jonathan Bedard 2020-10-19 11:52:33 PDT 
Comment on attachment 411767 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411767&action=review

> Tools/BuildSlaveSupport/ews-build/steps.py:2740
>  

unzip says that -o overwrites files without prompting....how did we get away with this in the first place?
Comment 3 Aakash Jain 2020-10-19 11:58:07 PDT 
In case of EWS, the file shouldn't exist previously. The uploaded file name is unique for each build.
Comment 4 Ling Ho 2020-10-19 13:27:25 PDT 
This is to eliminate the unecessary four lstat and stat calls everytime a file is getting extracted. But I haven't verified if -o indeed does that. Aakash have you?
Comment 5 EWS 2020-10-19 14:35:47 PDT 
Committed r268689: <https://trac.webkit.org/changeset/268689>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 411767 [details].
Comment 6 Radar WebKit Bug Importer 2020-10-19 14:36:19 PDT 
<rdar://problem/70456769>
Comment 7 Ling Ho 2020-10-19 14:38:43 PDT 
Looks like adding -o won't help. Unzip is still calling lstat and stat (twice each) before creating a file. So don't expect any performance improvement.
Comment 8 Aakash Jain 2020-10-26 10:27:05 PDT 
Discussed with Ling offline. As per him: I guess there is no harm leaving -o there. Might be the right thing to do because if for whatever reason the files were there before, we should overwrite.