Bug 217907 - Switch to a static pattern for DumpRenderTree preferences generation to avoid ambiguous rules
Summary: Switch to a static pattern for DumpRenderTree preferences generation to avoid...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-10-19 09:37 PDT by Sam Weinig
Modified: 2020-10-19 18:56 PDT (History)
3 users (show)

See Also:

Attachments
Patch (4.36 KB, patch)
2020-10-19 09:39 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (4.36 KB, patch)
2020-10-19 10:03 PDT, Sam Weinig 		simon.fraser: review+
sam: commit-queue+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2020-10-19 09:37:26 PDT 
Switch to a static pattern for DumpRenderTree preferences generation to mavoid ambiguous rules
Comment 1 Sam Weinig 2020-10-19 09:39:22 PDT 
Created attachment 411753 [details]
Patch
Comment 2 Darin Adler 2020-10-19 09:40:21 PDT 
mavoid
Comment 3 Sam Weinig 2020-10-19 10:03:39 PDT 
Created attachment 411757 [details]
Patch
Comment 4 Darin Adler 2020-10-19 11:11:27 PDT 
Comment on attachment 411757 [details]
Patch

Lets do more of this in the WebCore DerivedSources.make too?
Comment 5 Sam Weinig 2020-10-19 11:13:10 PDT 
(In reply to Darin Adler from comment #4)
> Comment on attachment 411757 [details]
> Patch
> 
> Lets do more of this in the WebCore DerivedSources.make too?

Yeah, if it works out here, I will do it for the rest as well.
Comment 6 Sam Weinig 2020-10-19 12:40:38 PDT 
Committed r268682: <https://trac.webkit.org/changeset/268682>
Comment 7 Radar WebKit Bug Importer 2020-10-19 12:41:20 PDT 
<rdar://problem/70451920>
Comment 8 Ryan Haddad 2020-10-19 15:08:13 PDT 
Reverted r268495, r268571, and r268682 for reason:

Caused failures for some internal build configurations

Committed r268693: <https://trac.webkit.org/changeset/268693>
Comment 9 Ryan Haddad 2020-10-19 18:56:51 PDT 
Re-landing these changes as the underlying issue may have been with CI infrastructure (and should now be resolved)

Committed r268705: <https://trac.webkit.org/changeset/268705>
Collapse All Comments
Expand All Comments
Add Comment