Bug 217811 - WebRTC VP9 Decoder should be able to use VTB
Summary: WebRTC VP9 Decoder should be able to use VTB
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-10-16 05:09 PDT by youenn fablet
Modified: 2020-10-21 10:15 PDT (History)
10 users (show)

See Also:

Attachments
Patch (45.27 KB, patch)
2020-10-16 05:15 PDT, youenn fablet 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (45.40 KB, patch)
2020-10-16 05:19 PDT, youenn fablet 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (45.41 KB, patch)
2020-10-16 05:48 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (42.99 KB, patch)
2020-10-16 06:00 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (59.77 KB, patch)
2020-10-19 02:35 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (59.48 KB, patch)
2020-10-19 02:38 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (60.81 KB, patch)
2020-10-19 06:06 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (60.92 KB, patch)
2020-10-21 08:43 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (7) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2020-10-16 05:09:30 PDT 
WebRTC VP9 Decoder should be able to use VTB
Comment 1 youenn fablet 2020-10-16 05:15:15 PDT 
Created attachment 411558 [details]
Patch
Comment 2 youenn fablet 2020-10-16 05:19:40 PDT 
Created attachment 411559 [details]
Patch
Comment 3 youenn fablet 2020-10-16 05:48:56 PDT 
Created attachment 411562 [details]
Patch
Comment 4 youenn fablet 2020-10-16 06:00:32 PDT 
Created attachment 411563 [details]
Patch
Comment 5 youenn fablet 2020-10-19 02:35:13 PDT 
Created attachment 411729 [details]
Patch
Comment 6 youenn fablet 2020-10-19 02:38:12 PDT 
Created attachment 411730 [details]
Patch
Comment 7 youenn fablet 2020-10-19 06:06:01 PDT 
Created attachment 411742 [details]
Patch
Comment 8 Eric Carlson 2020-10-19 09:09:35 PDT 
Comment on attachment 411742 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411742&action=review

> Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitVP9Decoder.cpp:81
> +    64, //sizeof(WebKitVP9Decoder),

Is this necessary?

> Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCVideoDecoderVTBVP9.mm:65
> +    return nullptr;

Is it worth logging here?

> Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCVideoDecoderVTBVP9.mm:70
> +    return nullptr;

Ditto
Comment 9 youenn fablet 2020-10-21 08:43:44 PDT 
Created attachment 411989 [details]
Patch for landing
Comment 10 EWS 2020-10-21 10:14:30 PDT 
Committed r268805: <https://trac.webkit.org/changeset/268805>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 411989 [details].
Comment 11 Radar WebKit Bug Importer 2020-10-21 10:15:25 PDT 
<rdar://problem/70534222>