Bug 217223 - WebDriver: start a https server too for tests
Summary: WebDriver: start a https server too for tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebDriver (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks: gtk-webdriver
  Show dependency tree / graph
 
Reported: 2020-10-02 06:11 PDT by Carlos Garcia Campos
Modified: 2020-10-20 03:59 PDT (History)
6 users (show)

See Also:

Attachments
Patch (6.88 KB, patch)
2020-10-20 02:09 PDT, Carlos Garcia Campos 		aperez: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2020-10-02 06:11:34 PDT 
It's required for some cookie tests:

  imported/w3c/webdriver/tests/get_named_cookie/get.py::test_get_cookie_with_same_site_flag[capabilities0-None]
  imported/w3c/webdriver/tests/get_named_cookie/get.py::test_get_cookie_with_same_site_flag[capabilities0-Lax]
  imported/w3c/webdriver/tests/get_named_cookie/get.py::test_get_cookie_with_same_site_flag[capabilities0-Strict]

    def inner(path, protocol="http", domain="", subdomain="", query="", fragment=""):
        domain = server_config["domains"][domain][subdomain]
>       port = server_config["ports"][protocol][0]
E       KeyError: 'https'
Comment 1 Radar WebKit Bug Importer 2020-10-09 06:12:15 PDT 
<rdar://problem/70136595>
Comment 2 Carlos Garcia Campos 2020-10-20 02:09:13 PDT 
Created attachment 411849 [details]
Patch
Comment 3 Adrian Perez 2020-10-20 03:51:36 PDT 
Comment on attachment 411849 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411849&action=review

> Tools/ChangeLog:9
> +        Handle HTTPS configuration in WebDriver WTP server.

Typo: WTP → WPT.

> Tools/Scripts/webkitpy/webdriver_tests/webdriver_w3c_web_server.py:98
> +        config['doc_root'] = doc_root

Much nicer to modify the data structure than blindly replacing %DOC_ROOT% =)
Comment 4 Carlos Garcia Campos 2020-10-20 03:59:02 PDT 
Committed r268723: <https://trac.webkit.org/changeset/268723>