Bug 217222 - WebDriver: add support for same site cookies
Summary: WebDriver: add support for same site cookies
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebDriver (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks: gtk-webdriver
  Show dependency tree / graph
 
Reported: 2020-10-02 06:04 PDT by Carlos Garcia Campos
Modified: 2020-10-02 23:29 PDT (History)
4 users (show)

See Also:

Attachments
Patch (8.94 KB, patch)
2020-10-02 06:10 PDT, Carlos Garcia Campos 		bburg: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2020-10-02 06:04:35 PDT 
We are currently ignoring the same site policy for cookies in WebDriver.
Comment 1 Carlos Garcia Campos 2020-10-02 06:10:17 PDT 
Created attachment 410318 [details]
Patch

There are still 3 same site cokies tests failing, but because they need the htps serer running and we don't start it for WebDriver tests.
Comment 2 BJ Burg 2020-10-02 09:56:59 PDT 
Comment on attachment 410318 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=410318&action=review

r=me, thanks Carlos! I'll look at hooking this up for safaridriver too.

> Source/WebKit/ChangeLog:8
> +        * UIProcess/Automation/Automation.json: Add CokieSameSitePolicy enum and sameSite member to Cookie object.

Nit: CookieSameSitePolicy
Comment 3 Carlos Garcia Campos 2020-10-02 23:28:20 PDT 
Committed r267919: <https://trac.webkit.org/changeset/267919>
Comment 4 Radar WebKit Bug Importer 2020-10-02 23:29:17 PDT 
<rdar://problem/69908887>