Bug 217204 - Remove unhelpful dom-static-property-for-in-iteration.html test
Summary: Remove unhelpful dom-static-property-for-in-iteration.html test
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-10-01 18:57 PDT by Sam Weinig
Modified: 2020-10-02 09:03 PDT (History)
3 users (show)

See Also:

Attachments
Patch (43.06 KB, patch)
2020-10-01 19:00 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2020-10-01 18:57:12 PDT 
Remove unhelpful dom-static-property-for-in-iteration.html test
Comment 1 Sam Weinig 2020-10-01 19:00:45 PDT 
Created attachment 410300 [details]
Patch
Comment 2 Sam Weinig 2020-10-01 19:01:18 PDT 
Iteration order for builtin attributes, operations and constants of WebIDL objects is not currently defined, so the test dom-static-property-for-in-iteration.html,is just testing what we happen to currently do. This is largely unhelpfuland frustrating to maintain as different ports enabling/disabling featuresmeans each port needed a seperate result, and any time something was added, removedor moved, all the results need to be updated. There are plenty of other teststhat ensure we have these properties, so removing this is not a loss.
Comment 3 Sam Weinig 2020-10-01 19:01:56 PDT 
Interested if others think this test remains useful, but I think we should just get rid of it.
Comment 4 EWS 2020-10-02 09:02:02 PDT 
Committed r267884: <https://trac.webkit.org/changeset/267884>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 410300 [details].