Bug 217162 - [WebIDL] Add support for non-nullable optional wrapper type arguments to operations
Summary: [WebIDL] Add support for non-nullable optional wrapper type arguments to oper...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords: InRadar
Depends on: 219165
Blocks: 171589
  Show dependency tree / graph
 
Reported: 2020-09-30 19:37 PDT by Sam Weinig
Modified: 2020-11-19 09:06 PST (History)
6 users (show)

See Also:

Attachments
Patch (12.87 KB, patch)
2020-09-30 19:54 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (38.57 KB, patch)
2020-10-01 09:53 PDT, Sam Weinig 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (39.82 KB, patch)
2020-10-01 11:29 PDT, Sam Weinig 		cdumez: review+
sam: commit-queue+
Details | Formatted Diff | Diff
Patch (39.81 KB, patch)
2020-10-01 17:57 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2020-09-30 19:37:32 PDT 
[WebIDL] Add support for non-nullable optional wrapper type arguments to operations
Comment 1 Sam Weinig 2020-09-30 19:54:16 PDT 
Created attachment 410197 [details]
Patch
Comment 2 Sam Weinig 2020-10-01 09:53:25 PDT 
Created attachment 410241 [details]
Patch
Comment 3 Chris Dumez 2020-10-01 09:54:27 PDT 
Comment on attachment 410241 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=410241&action=review

> LayoutTests/ChangeLog:12
> +2020-09-30  Sam Weinig  <weinig@apple.com>

double changelog.
Comment 4 Sam Weinig 2020-10-01 11:24:11 PDT 
(In reply to Chris Dumez from comment #3)
> Comment on attachment 410241 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=410241&action=review
> 
> > LayoutTests/ChangeLog:12
> > +2020-09-30  Sam Weinig  <weinig@apple.com>
> 
> double changelog.

No really close to ready for review yet. Just using the bots to build things for me while my computer is busy :).
Comment 5 Chris Dumez 2020-10-01 11:25:08 PDT 
(In reply to Sam Weinig from comment #4)
> (In reply to Chris Dumez from comment #3)
> > Comment on attachment 410241 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=410241&action=review
> > 
> > > LayoutTests/ChangeLog:12
> > > +2020-09-30  Sam Weinig  <weinig@apple.com>
> > 
> > double changelog.
> 
> No really close to ready for review yet. Just using the bots to build things
> for me while my computer is busy :).

Yeah but I got curious and could not help but look :P
Comment 6 Sam Weinig 2020-10-01 11:29:28 PDT 
(In reply to Chris Dumez from comment #5)
> (In reply to Sam Weinig from comment #4)
> > (In reply to Chris Dumez from comment #3)
> > > Comment on attachment 410241 [details]
> > > Patch
> > > 
> > > View in context:
> > > https://bugs.webkit.org/attachment.cgi?id=410241&action=review
> > > 
> > > > LayoutTests/ChangeLog:12
> > > > +2020-09-30  Sam Weinig  <weinig@apple.com>
> > > 
> > > double changelog.
> > 
> > No really close to ready for review yet. Just using the bots to build things
> > for me while my computer is busy :).
> 
> Yeah but I got curious and could not help but look :P

It was good, I probably would have missed it :).
Comment 7 Sam Weinig 2020-10-01 11:29:36 PDT 
Created attachment 410246 [details]
Patch
Comment 8 Sam Weinig 2020-10-01 12:06:03 PDT 
I think it should be ready for review now.
Comment 9 Chris Dumez 2020-10-01 12:21:52 PDT 
Comment on attachment 410246 [details]
Patch

r=me
Comment 10 Chris Dumez 2020-10-01 16:22:04 PDT 
Re-running Mac-wk2 EWS since I think the failing test is unrelated.
Comment 11 Sam Weinig 2020-10-01 17:57:06 PDT 
Created attachment 410293 [details]
Patch
Comment 12 EWS 2020-10-01 18:42:20 PDT 
Committed r267865: <https://trac.webkit.org/changeset/267865>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 410293 [details].
Comment 13 Chris Dumez 2020-11-19 08:56:08 PST 
Comment on attachment 410293 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=410293&action=review

> Source/WebCore/Modules/geolocation/Geolocation.idl:-35
> -                            optional PositionErrorCallback? errorCallback,

I don't think we should have made those changes. Those parameters are nullable in both Firefox and Chrome. Also, there are WPT tests that fail unless this parameter is nullable. I am planning on reverting the changes to Geolocation.idl as a result.
Comment 14 Radar WebKit Bug Importer 2020-11-19 08:56:23 PST 
<rdar://problem/71588509>