Bug 217055 - Add Bounds Check Elimination validation for debugging.
Summary: Add Bounds Check Elimination validation for debugging.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-09-28 10:22 PDT by Mark Lam
Modified: 2020-09-28 21:55 PDT (History)
8 users (show)

See Also:

Attachments
proposed patch. (21.82 KB, patch)
2020-09-28 19:07 PDT, Mark Lam 		keith_miller: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2020-09-28 10:22:05 PDT 
rdar://69122891
Comment 1 Mark Lam 2020-09-28 19:07:56 PDT 
Created attachment 409946 [details]
proposed patch.
Comment 2 Keith Miller 2020-09-28 19:13:10 PDT 
Comment on attachment 409946 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=409946&action=review

r=me with nit

> Source/JavaScriptCore/dfg/DFGConstantFoldingPhase.cpp:-381
> -

Undo please.

> Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:4654
> +        RELEASE_ASSERT(Options::validateBoundsCheckElimination());

Does this really do anything?
Comment 3 Mark Lam 2020-09-28 19:20:29 PDT 
Comment on attachment 409946 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=409946&action=review

Thanks for the review.

>> Source/JavaScriptCore/dfg/DFGConstantFoldingPhase.cpp:-381
>> -
> 
> Undo please.

will do.

>> Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:4654
>> +        RELEASE_ASSERT(Options::validateBoundsCheckElimination());
> 
> Does this really do anything?

Just a sanity check that this node should never be emitted if the option isn't enabled.  I suppose there's no strong reason it needs to be a RELEASE_ASSERT.  I'll change it to an ASSERT.
Comment 4 Mark Lam 2020-09-28 21:55:16 PDT 
Landed in r267726: <http://trac.webkit.org/r267726>.