Bug 217049 - Fix test failures inadventently introduced in r267644
Summary: Fix test failures inadventently introduced in r267644
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-09-28 03:20 PDT by Angelos Oikonomopoulos
Modified: 2020-09-29 01:09 PDT (History)
8 users (show)

See Also:

Attachments
Patch (2.73 KB, patch)
2020-09-28 03:23 PDT, Angelos Oikonomopoulos 		no flags Details | Formatted Diff | Diff
Patch (2.90 KB, patch)
2020-09-28 03:33 PDT, Angelos Oikonomopoulos 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Angelos Oikonomopoulos 2020-09-28 03:20:45 PDT 
Fix test failures inadventently introduced in r267644
Comment 1 Angelos Oikonomopoulos 2020-09-28 03:23:47 PDT 
Created attachment 409878 [details]
Patch
Comment 2 Angelos Oikonomopoulos 2020-09-28 03:33:43 PDT 
Created attachment 409881 [details]
Patch
Comment 3 EWS 2020-09-28 05:25:05 PDT 
Committed r267696: <https://trac.webkit.org/changeset/267696>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 409881 [details].
Comment 4 Radar WebKit Bug Importer 2020-09-28 05:26:16 PDT 
<rdar://problem/69693227>
Comment 5 Darin Adler 2020-09-28 08:19:20 PDT 
Comment on attachment 409881 [details]
Patch

It doesn’t make sense that these would lead to test failures. The test tool would strip the spaces. These scripts would not be able to detect that the spaces were stripped. Did tests really fail? How?
Comment 6 Darin Adler 2020-09-28 10:33:57 PDT 
Oh, I think I understand. These were broken when they were run, not with DumpRenderTree or WebKitTestRunner, but in some other JavaScript-only way.
Comment 7 Angelos Oikonomopoulos 2020-09-29 01:09:28 PDT 
(In reply to Darin Adler from comment #6)
> Oh, I think I understand. These were broken when they were run, not with
> DumpRenderTree or WebKitTestRunner, but in some other JavaScript-only way.

Right, those are getting run by run-jsc-stress-tests.