Bug 217028 - Refactor test runner code to cut down on copy/paste code and long-winded repetitive idioms
Summary: Refactor test runner code to cut down on copy/paste code and long-winded repe...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Darin Adler
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-09-26 22:21 PDT by Darin Adler
Modified: 2020-09-29 14:40 PDT (History)
9 users (show)

See Also:

Attachments
Patch (676.39 KB, patch)
2020-09-27 11:46 PDT, Darin Adler 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (676.70 KB, patch)
2020-09-27 11:51 PDT, Darin Adler 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (681.29 KB, patch)
2020-09-27 11:57 PDT, Darin Adler 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (681.47 KB, patch)
2020-09-27 12:44 PDT, Darin Adler 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (681.30 KB, patch)
2020-09-27 12:50 PDT, Darin Adler 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (681.30 KB, patch)
2020-09-27 12:55 PDT, Darin Adler 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (683.27 KB, patch)
2020-09-27 15:02 PDT, Darin Adler 		no flags Details | Formatted Diff | Diff
Patch (683.24 KB, patch)
2020-09-27 18:46 PDT, Darin Adler 		no flags Details | Formatted Diff | Diff
Patch (688.20 KB, patch)
2020-09-27 18:55 PDT, Darin Adler 		no flags Details | Formatted Diff | Diff
Patch (688.25 KB, patch)
2020-09-27 21:47 PDT, Darin Adler 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (688.56 KB, patch)
2020-09-27 23:06 PDT, Darin Adler 		no flags Details | Formatted Diff | Diff
Patch (687.27 KB, patch)
2020-09-28 09:57 PDT, Darin Adler 		no flags Details | Formatted Diff | Diff
Patch (692.31 KB, patch)
2020-09-28 19:35 PDT, Darin Adler 		sam: review+
Details | Formatted Diff | Diff
Show Obsolete (12) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2020-09-26 22:21:33 PDT 
Refactor test runner code to cut down on copy/paste code and long-winded repetitive idioms
Comment 1 Darin Adler 2020-09-27 11:46:40 PDT Comment hidden (obsolete)
Comment 2 Darin Adler 2020-09-27 11:47:06 PDT 
Not setting review? yet because I must have made at least one mistake in all the global replaces and refactoring.
Comment 3 Darin Adler 2020-09-27 11:51:48 PDT Comment hidden (obsolete)
Comment 4 Darin Adler 2020-09-27 11:57:09 PDT Comment hidden (obsolete)
Comment 5 Darin Adler 2020-09-27 12:44:44 PDT Comment hidden (obsolete)
Comment 6 Darin Adler 2020-09-27 12:50:39 PDT Comment hidden (obsolete)
Comment 7 Darin Adler 2020-09-27 12:55:13 PDT Comment hidden (obsolete)
Comment 8 Darin Adler 2020-09-27 15:02:47 PDT Comment hidden (obsolete)
Comment 9 Darin Adler 2020-09-27 18:46:52 PDT Comment hidden (obsolete)
Comment 10 Darin Adler 2020-09-27 18:55:49 PDT Comment hidden (obsolete)
Comment 11 Darin Adler 2020-09-27 21:47:45 PDT Comment hidden (obsolete)
Comment 12 Darin Adler 2020-09-27 23:06:47 PDT Comment hidden (obsolete)
Comment 13 Darin Adler 2020-09-28 09:57:13 PDT Comment hidden (obsolete)
Comment 14 Darin Adler 2020-09-28 19:35:47 PDT 
Created attachment 409952 [details]
Patch
Comment 15 Darin Adler 2020-09-29 13:12:12 PDT 
Working now, so ready for review.
Comment 16 Sam Weinig 2020-09-29 14:15:06 PDT 
Comment on attachment 409952 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409952&action=review

> Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp:96
> +static JSContextRef mainJSContext()

I would prefer this be called mainFrameJSContext, just because main on its own is so ambiguous, but I feel this in a very minor way.
Comment 17 Darin Adler 2020-09-29 14:39:03 PDT 
Committed r267761: <https://trac.webkit.org/changeset/267761>
Comment 18 Radar WebKit Bug Importer 2020-09-29 14:40:22 PDT 
<rdar://problem/69764444>