Bug 217012 - [SOUP] WebSocket: cookies set in request don't appear in the inspector
Summary: [SOUP] WebSocket: cookies set in request don't appear in the inspector
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2020-09-26 07:32 PDT by Carlos Garcia Campos
Modified: 2020-09-27 05:46 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.78 KB, patch)
2020-09-26 07:35 PDT, Carlos Garcia Campos 		mcatanzaro: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2020-09-26 07:32:44 PDT 
Cookies are set by libsoup and we are notifying about the handshake being sent before the cookie header is added to the request.
Comment 1 Carlos Garcia Campos 2020-09-26 07:35:20 PDT 
Created attachment 409776 [details]
Patch
Comment 2 Michael Catanzaro 2020-09-26 08:58:20 PDT 
Comment on attachment 409776 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409776&action=review

> Source/WebKit/NetworkProcess/soup/WebSocketTaskSoup.cpp:83
> +    g_signal_connect(msg, "starting", G_CALLBACK(+[](SoupMessage* msg, WebSocketTask* task) {

+[] to convert to vanilla function pointer so we can use it in a signal callback is amazing... I didn't know this was possible!
Comment 3 Carlos Garcia Campos 2020-09-27 05:46:06 PDT 
Committed r267655: <https://trac.webkit.org/changeset/267655>