217008 – Test bug for code review timeouts

Bug 217008 - Test bug for code review timeouts

Summary: Test bug for code review timeouts

Status:	ASSIGNED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	WebGL (show other bugs)
Version:	WebKit Nightly Build
Hardware:	Unspecified Unspecified

Importance:	P2 Normal
Assignee:	Kenneth Russell

URL:
Keywords:	InRadar

Depends on:
Blocks:

Reported:	2020-09-25 21:39 PDT by Kenneth Russell
Modified:	2020-10-28 17:18 PDT (History)
CC List:	12 users (show)

See Also:

Attachments
Patch (4.63 KB, patch) 2020-09-25 21:40 PDT, Kenneth Russell	no flags	Details \| Formatted Diff \| Diff
Patch (4.63 KB, patch) 2020-09-28 10:08 PDT, Kenneth Russell	no flags	Details \| Formatted Diff \| Diff
Patch (4.63 KB, patch) 2020-09-28 10:09 PDT, Kenneth Russell	no flags	Details \| Formatted Diff \| Diff
Patch (4.63 KB, patch) 2020-09-28 10:17 PDT, Kenneth Russell	kbr: review?	Details \| Formatted Diff \| Diff
test patch (4.63 KB, patch) 2020-09-28 17:45 PDT, Joey Arhar	no flags	Details \| Formatted Diff \| Diff
test patch upload 2 (4.63 KB, patch) 2020-09-28 17:46 PDT, Joey Arhar	no flags	Details \| Formatted Diff \| Diff
test patch upload 3 (4.63 KB, patch) 2020-09-28 17:46 PDT, Joey Arhar	no flags	Details \| Formatted Diff \| Diff
test patch 4 (4.63 KB, patch) 2020-10-09 20:17 PDT, Joey Arhar	no flags	Details \| Formatted Diff \| Diff
test (4.63 KB, patch) 2020-10-10 12:01 PDT, Joey Arhar	no flags	Details \| Formatted Diff \| Diff
test (4.63 KB, patch) 2020-10-12 08:54 PDT, Joey Arhar	no flags	Details \| Formatted Diff \| Diff
test (4.63 KB, patch) 2020-10-13 13:29 PDT, Joey Arhar	no flags	Details \| Formatted Diff \| Diff
test (4.63 KB, patch) 2020-10-13 15:25 PDT, Joey Arhar	no flags	Details \| Formatted Diff \| Diff
test (4.63 KB, patch) 2020-10-13 16:33 PDT, Joey Arhar	no flags	Details \| Formatted Diff \| Diff
test (4.63 KB, patch) 2020-10-13 17:30 PDT, Joey Arhar	no flags	Details \| Formatted Diff \| Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Kenneth Russell 2020-09-25 21:39:30 PDT

This is a test bug for diagnosing timeouts with the code review tool when using Chrome - crbug.com/1132508 .

Comment 1 Kenneth Russell 2020-09-25 21:40:17 PDT

Created attachment 409769 [details]
Patch

Comment 2 Kenneth Russell 2020-09-28 10:08:16 PDT

Created attachment 409894 [details]
Patch

Comment 3 Kenneth Russell 2020-09-28 10:09:57 PDT

Created attachment 409895 [details]
Patch

Comment 4 Kenneth Russell 2020-09-28 10:17:36 PDT

Created attachment 409897 [details]
Patch

Comment 5 Joey Arhar 2020-09-28 17:45:27 PDT

Created attachment 409932 [details]
test patch

Comment 6 Joey Arhar 2020-09-28 17:46:02 PDT

Created attachment 409933 [details]
test patch upload 2

Comment 7 Joey Arhar 2020-09-28 17:46:24 PDT

Created attachment 409934 [details]
test patch upload 3

Comment 8 Joey Arhar 2020-09-28 17:47:05 PDT

Comment on attachment 409897 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409897&action=review

> Source/WebCore/ChangeLog:10
> +        * html/canvas/WebGLRenderingContextBase.cpp:

test comment 1

Comment 9 Joey Arhar 2020-09-28 17:47:28 PDT

Comment on attachment 409897 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409897&action=review

> Source/WebCore/ChangeLog:11
> +        (WebCore::WebGLRenderingContextBase::initializeNewContext):

test comment 2

Comment 10 Joey Arhar 2020-09-28 17:47:47 PDT

Comment on attachment 409897 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409897&action=review

> Source/WebCore/ChangeLog:12
> +        (WebCore::WebGLRenderingContextBase::bindAttribLocation):

test comment 3

Comment 11 Joey Arhar 2020-09-28 17:48:06 PDT

Comment on attachment 409897 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409897&action=review

> Source/WebCore/ChangeLog:13
> +        (WebCore::WebGLRenderingContextBase::createFramebuffer):

test comment 4

Comment 12 Joey Arhar 2020-09-28 17:48:16 PDT

Comment on attachment 409897 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409897&action=review

> Source/WebCore/ChangeLog:14
> +        (WebCore::WebGLRenderingContextBase::drawArrays):

test comment 5

Comment 13 Joey Arhar 2020-09-28 17:49:18 PDT

Comment on attachment 409897 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409897&action=review

> Source/WebCore/ChangeLog:15
> +        (WebCore::WebGLRenderingContextBase::getUniformLocation):

test comment 6

Comment 14 Joey Arhar 2020-09-28 17:49:46 PDT

View in context: https://bugs.webkit.org/attachment.cgi?id=409897&action=review

> Source/WebCore/ChangeLog:15
> +        (WebCore::WebGLRenderingContextBase::getUniformLocation):

test comment 6

Comment 15 Joey Arhar 2020-09-28 17:51:25 PDT

Comment on attachment 409897 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409897&action=review

> Source/WebCore/ChangeLog:16
> +        (WebCore::WebGLRenderingContextBase::readPixels):

test comment 7

Comment 16 Joey Arhar 2020-09-28 17:51:40 PDT

Comment on attachment 409897 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409897&action=review

> Source/WebCore/ChangeLog:17
> +        (WebCore::WebGLRenderingContextBase::texSubImage2DBase):

test comment 8

Comment 17 Joey Arhar 2020-09-28 17:53:20 PDT

Comment on attachment 409897 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409897&action=review

> Source/WebCore/ChangeLog:18
> +        (WebCore::WebGLRenderingContextBase::texParameter):

test comment 9

Comment 18 Joey Arhar 2020-09-28 17:53:33 PDT

Comment on attachment 409897 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409897&action=review

> Source/WebCore/ChangeLog:19
> +

test comment 10

Comment 19 Joey Arhar 2020-09-28 17:54:32 PDT

Comment on attachment 409897 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409897&action=review

> Source/WebCore/ChangeLog:20
>  2020-09-23  Chris Dumez  <cdumez@apple.com>

test comment 11

Comment 20 Joey Arhar 2020-09-28 17:54:42 PDT

Comment on attachment 409897 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409897&action=review

> Source/WebCore/ChangeLog:21
>  

test comment 12

Comment 21 Joey Arhar 2020-09-28 17:55:23 PDT

Comment on attachment 409897 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409897&action=review

> Source/WebCore/ChangeLog:22
>          webaudio/AudioBufferSource/audiobuffersource-playbackrate.html is crashing

test comment 13

Comment 22 Joey Arhar 2020-09-28 17:55:35 PDT

Comment on attachment 409897 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409897&action=review

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:844
>  

test comment 14

Comment 23 Joey Arhar 2020-09-28 17:56:12 PDT

Comment on attachment 409897 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409897&action=review

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:845
>  void WebGLRenderingContextBase::initializeNewContext()

test comment 15

Comment 24 Joey Arhar 2020-09-28 17:56:27 PDT

Comment on attachment 409897 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409897&action=review

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:846
>  {

test comment 16

Comment 25 Joey Arhar 2020-09-28 17:57:07 PDT

Comment on attachment 409897 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409897&action=review

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:847
> +    //

test comment 17

Comment 26 Joey Arhar 2020-09-28 17:57:26 PDT

Comment on attachment 409897 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409897&action=review

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:848
> +    //

test comment 18

Comment 27 Joey Arhar 2020-09-28 17:57:50 PDT

Comment on attachment 409897 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409897&action=review

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:849
> +    // TESTING

test comment 19

Comment 28 Joey Arhar 2020-09-28 17:58:04 PDT

Comment on attachment 409897 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409897&action=review

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:850
> +    //

test comment 20

Comment 29 Joey Arhar 2020-09-28 17:59:18 PDT

Comment on attachment 409897 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409897&action=review

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:851
> +    //

test comment 21

Comment 30 Joey Arhar 2020-09-28 17:59:41 PDT

Comment on attachment 409897 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409897&action=review

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:852
> +

test comment 22

Comment 31 Joey Arhar 2020-09-28 17:59:58 PDT

Comment on attachment 409897 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409897&action=review

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:853
>      ASSERT(!m_contextLost);

test comment 23

Comment 32 Joey Arhar 2020-09-28 18:00:15 PDT

Comment on attachment 409897 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409897&action=review

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:854
>      m_needsUpdate = true;

test comment 24

Comment 33 Joey Arhar 2020-09-28 18:01:10 PDT

Comment on attachment 409897 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409897&action=review

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:855
>      m_markedCanvasDirty = false;

test comment 25

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1349
>  

test comment 26

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1350
>  void WebGLRenderingContextBase::bindAttribLocation(WebGLProgram& program, GCGLuint index, const String& name)

test comment 27

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1351
>  {

test comment 28

Comment 34 Joey Arhar 2020-09-28 18:03:15 PDT

Comment on attachment 409897 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409897&action=review

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1352
> +    //

test comment 29

Comment 35 Joey Arhar 2020-09-29 10:01:23 PDT

Comment on attachment 409932 [details]
test patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409932&action=review

> Source/WebCore/ChangeLog:1
> +2020-09-25  Kenneth Russell  <kbr@chromium.org>

test comment 1

Comment 36 Joey Arhar 2020-09-29 10:01:49 PDT

Comment on attachment 409932 [details]
test patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409932&action=review

> Source/WebCore/ChangeLog:2
> +

test comment 2

Comment 37 Joey Arhar 2020-09-29 10:02:20 PDT

Comment on attachment 409932 [details]
test patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409932&action=review

> Source/WebCore/ChangeLog:3
> +        Test bug for code review timeouts

test comment 3

Comment 38 Joey Arhar 2020-09-29 10:03:20 PDT

Comment on attachment 409932 [details]
test patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409932&action=review

> Source/WebCore/ChangeLog:3
> +        Test bug for code review timeouts

test comment 3

Comment 39 Joey Arhar 2020-09-29 10:04:30 PDT

Comment on attachment 409932 [details]
test patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409932&action=review

> Source/WebCore/ChangeLog:3
> +        Test bug for code review timeouts

test comment 3

Comment 40 Joey Arhar 2020-09-29 10:05:34 PDT

Comment on attachment 409932 [details]
test patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409932&action=review

>>>> Source/WebCore/ChangeLog:3
>>>> +        Test bug for code review timeouts
>>> 
>>> test comment 3
>> 
>> test comment 3
> 
> test comment 3

test comment 3

> Source/WebCore/ChangeLog:4
> +        https://bugs.webkit.org/show_bug.cgi?id=217008

test comment 4

Comment 41 Joey Arhar 2020-09-29 10:09:27 PDT

Comment on attachment 409932 [details]
test patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409932&action=review

>>>>> Source/WebCore/ChangeLog:3
>>>>> +        Test bug for code review timeouts
>>>> 
>>>> test comment 3
>>> 
>>> test comment 3
>> 
>> test comment 3
> 
> test comment 3

test comment 3

Comment 42 Joey Arhar 2020-09-29 10:13:02 PDT

Comment on attachment 409932 [details]
test patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409932&action=review

> Source/WebCore/ChangeLog:7
> +

test comment 5

Comment 43 Joey Arhar 2020-09-29 10:13:25 PDT

Comment on attachment 409932 [details]
test patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409932&action=review

> Source/WebCore/ChangeLog:8
> +        No-op changes to have a place for code reviews.

test comment 6

Comment 44 Joey Arhar 2020-09-29 10:16:27 PDT

Comment on attachment 409932 [details]
test patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409932&action=review

> Source/WebCore/ChangeLog:10
> +        * html/canvas/WebGLRenderingContextBase.cpp:

test comment 7

Comment 45 Joey Arhar 2020-09-29 10:16:40 PDT

Comment on attachment 409932 [details]
test patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409932&action=review

> Source/WebCore/ChangeLog:11
> +        (WebCore::WebGLRenderingContextBase::initializeNewContext):

test comment 8

Comment 46 Joey Arhar 2020-09-29 10:17:35 PDT

Comment on attachment 409932 [details]
test patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409932&action=review

> Source/WebCore/ChangeLog:13
> +        (WebCore::WebGLRenderingContextBase::createFramebuffer):

test comment 9

Comment 47 Joey Arhar 2020-09-29 10:17:50 PDT

Comment on attachment 409932 [details]
test patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409932&action=review

> Source/WebCore/ChangeLog:14
> +        (WebCore::WebGLRenderingContextBase::drawArrays):

test comment 10

Comment 48 Joey Arhar 2020-09-29 10:18:26 PDT

Comment on attachment 409932 [details]
test patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409932&action=review

> Source/WebCore/ChangeLog:16
> +        (WebCore::WebGLRenderingContextBase::readPixels):

test comment 11

Comment 49 Joey Arhar 2020-09-29 10:19:07 PDT

Comment on attachment 409932 [details]
test patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409932&action=review

>> Source/WebCore/ChangeLog:16
>> +        (WebCore::WebGLRenderingContextBase::readPixels):
> 
> test comment 11

test comment 11

Comment 50 Joey Arhar 2020-09-29 10:31:20 PDT

Comment on attachment 409932 [details]
test patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409932&action=review

> Source/WebCore/ChangeLog:18
> +        (WebCore::WebGLRenderingContextBase::texParameter):

test comment 12

Comment 51 Joey Arhar 2020-09-29 10:31:34 PDT

Comment on attachment 409932 [details]
test patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409932&action=review

> Source/WebCore/ChangeLog:19
> +

test comment 13

Comment 52 Joey Arhar 2020-09-29 10:32:30 PDT

Comment on attachment 409932 [details]
test patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409932&action=review

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:844
>  

test comment 14

Comment 53 Joey Arhar 2020-09-29 10:32:46 PDT

Comment on attachment 409932 [details]
test patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409932&action=review

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:845
>  void WebGLRenderingContextBase::initializeNewContext()

test comment 15

Comment 54 Joey Arhar 2020-09-29 12:05:25 PDT

Comment on attachment 409933 [details]
test patch upload 2

View in context: https://bugs.webkit.org/attachment.cgi?id=409933&action=review

> Source/WebCore/ChangeLog:2
> +

comment 1

Comment 55 Joey Arhar 2020-09-29 12:05:46 PDT

Comment on attachment 409933 [details]
test patch upload 2

View in context: https://bugs.webkit.org/attachment.cgi?id=409933&action=review

> Source/WebCore/ChangeLog:3
> +        Test bug for code review timeouts

comment 2

Comment 56 Joey Arhar 2020-09-29 12:06:56 PDT

Comment on attachment 409933 [details]
test patch upload 2

View in context: https://bugs.webkit.org/attachment.cgi?id=409933&action=review

> Source/WebCore/ChangeLog:5
> +

comment 3

Comment 57 Joey Arhar 2020-09-29 12:07:12 PDT

Comment on attachment 409933 [details]
test patch upload 2

View in context: https://bugs.webkit.org/attachment.cgi?id=409933&action=review

> Source/WebCore/ChangeLog:6
> +        Reviewed by NOBODY (OOPS!).

comment 4

Comment 58 Joey Arhar 2020-09-29 12:07:47 PDT

Comment on attachment 409933 [details]
test patch upload 2

View in context: https://bugs.webkit.org/attachment.cgi?id=409933&action=review

> Source/WebCore/ChangeLog:8
> +        No-op changes to have a place for code reviews.

comment 5

Comment 59 Joey Arhar 2020-09-29 12:08:35 PDT

Comment on attachment 409933 [details]
test patch upload 2

View in context: https://bugs.webkit.org/attachment.cgi?id=409933&action=review

> Source/WebCore/ChangeLog:10
> +        * html/canvas/WebGLRenderingContextBase.cpp:

comment 6

Comment 60 Joey Arhar 2020-09-29 12:08:49 PDT

Comment on attachment 409933 [details]
test patch upload 2

View in context: https://bugs.webkit.org/attachment.cgi?id=409933&action=review

> Source/WebCore/ChangeLog:11
> +        (WebCore::WebGLRenderingContextBase::initializeNewContext):

comment 7

Comment 61 Joey Arhar 2020-09-29 12:09:34 PDT

Comment on attachment 409933 [details]
test patch upload 2

View in context: https://bugs.webkit.org/attachment.cgi?id=409933&action=review

> Source/WebCore/ChangeLog:13
> +        (WebCore::WebGLRenderingContextBase::createFramebuffer):

comment 8

Comment 62 Joey Arhar 2020-09-29 12:09:50 PDT

Comment on attachment 409933 [details]
test patch upload 2

View in context: https://bugs.webkit.org/attachment.cgi?id=409933&action=review

> Source/WebCore/ChangeLog:14
> +        (WebCore::WebGLRenderingContextBase::drawArrays):

comment 9

Comment 63 Joey Arhar 2020-09-29 12:10:43 PDT

Comment on attachment 409933 [details]
test patch upload 2

View in context: https://bugs.webkit.org/attachment.cgi?id=409933&action=review

> Source/WebCore/ChangeLog:16
> +        (WebCore::WebGLRenderingContextBase::readPixels):

comment 10

Comment 64 Joey Arhar 2020-09-29 12:10:57 PDT

Comment on attachment 409933 [details]
test patch upload 2

View in context: https://bugs.webkit.org/attachment.cgi?id=409933&action=review

> Source/WebCore/ChangeLog:17
> +        (WebCore::WebGLRenderingContextBase::texSubImage2DBase):

comment 11

Comment 65 Joey Arhar 2020-09-29 12:11:46 PDT

Comment on attachment 409933 [details]
test patch upload 2

View in context: https://bugs.webkit.org/attachment.cgi?id=409933&action=review

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:844
>  

comment 12

Comment 66 Joey Arhar 2020-09-29 12:12:33 PDT

Comment on attachment 409933 [details]
test patch upload 2

View in context: https://bugs.webkit.org/attachment.cgi?id=409933&action=review

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:845
>  void WebGLRenderingContextBase::initializeNewContext()

comment 13

Comment 67 Joey Arhar 2020-09-29 12:13:17 PDT

Comment on attachment 409933 [details]
test patch upload 2

View in context: https://bugs.webkit.org/attachment.cgi?id=409933&action=review

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:847
> +    //

comment 14

Comment 68 Joey Arhar 2020-09-29 12:14:15 PDT

Comment on attachment 409933 [details]
test patch upload 2

View in context: https://bugs.webkit.org/attachment.cgi?id=409933&action=review

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:849
> +    // TESTING

comment 15

Comment 69 Joey Arhar 2020-09-29 12:24:40 PDT

Comment on attachment 409933 [details]
test patch upload 2

View in context: https://bugs.webkit.org/attachment.cgi?id=409933&action=review

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:852
> +

comment 16

Comment 70 Joey Arhar 2020-09-29 12:25:05 PDT

Comment on attachment 409933 [details]
test patch upload 2

View in context: https://bugs.webkit.org/attachment.cgi?id=409933&action=review

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:853
>      ASSERT(!m_contextLost);

comment 17

Comment 71 Joey Arhar 2020-09-29 14:55:41 PDT

Comment on attachment 409934 [details]
test patch upload 3

View in context: https://bugs.webkit.org/attachment.cgi?id=409934&action=review

> Source/WebCore/ChangeLog:1
> +2020-09-25  Kenneth Russell  <kbr@chromium.org>

comment 1

Comment 72 Radar WebKit Bug Importer 2020-10-02 21:40:18 PDT

<rdar://problem/69907701>

Comment 73 Joey Arhar 2020-10-09 20:17:09 PDT

Created attachment 411001 [details]
test patch 4

Comment 74 Joey Arhar 2020-10-09 20:17:42 PDT

Comment on attachment 411001 [details]
test patch 4

View in context: https://bugs.webkit.org/attachment.cgi?id=411001&action=review

> Source/WebCore/ChangeLog:1
> +2020-09-25  Kenneth Russell  <kbr@chromium.org>

comment 1

Comment 75 Joey Arhar 2020-10-09 20:18:19 PDT

Comment on attachment 411001 [details]
test patch 4

View in context: https://bugs.webkit.org/attachment.cgi?id=411001&action=review

> Source/WebCore/ChangeLog:2
> +

comment 2

Comment 76 Joey Arhar 2020-10-09 20:19:24 PDT

Comment on attachment 411001 [details]
test patch 4

View in context: https://bugs.webkit.org/attachment.cgi?id=411001&action=review

> Source/WebCore/ChangeLog:3
> +        Test bug for code review timeouts

comment 3

Comment 77 Joey Arhar 2020-10-09 20:19:48 PDT

Comment on attachment 411001 [details]
test patch 4

View in context: https://bugs.webkit.org/attachment.cgi?id=411001&action=review

> Source/WebCore/ChangeLog:4
> +        https://bugs.webkit.org/show_bug.cgi?id=217008

comment 4

Comment 78 Joey Arhar 2020-10-09 20:23:13 PDT

Comment on attachment 411001 [details]
test patch 4

View in context: https://bugs.webkit.org/attachment.cgi?id=411001&action=review

> Source/WebCore/ChangeLog:5
> +

5

> Source/WebCore/ChangeLog:6
> +        Reviewed by NOBODY (OOPS!).

6

Comment 79 Joey Arhar 2020-10-09 20:23:50 PDT

Comment on attachment 411001 [details]
test patch 4

View in context: https://bugs.webkit.org/attachment.cgi?id=411001&action=review

> Source/WebCore/ChangeLog:7
> +

7

Comment 80 Joey Arhar 2020-10-09 20:28:59 PDT

Comment on attachment 411001 [details]
test patch 4

View in context: https://bugs.webkit.org/attachment.cgi?id=411001&action=review

> Source/WebCore/ChangeLog:9
> +

9

Comment 81 Joey Arhar 2020-10-09 20:29:11 PDT

Comment on attachment 411001 [details]
test patch 4

View in context: https://bugs.webkit.org/attachment.cgi?id=411001&action=review

> Source/WebCore/ChangeLog:10
> +        * html/canvas/WebGLRenderingContextBase.cpp:

10

Comment 82 Joey Arhar 2020-10-09 20:29:24 PDT

Comment on attachment 411001 [details]
test patch 4

View in context: https://bugs.webkit.org/attachment.cgi?id=411001&action=review

> Source/WebCore/ChangeLog:11
> +        (WebCore::WebGLRenderingContextBase::initializeNewContext):

11

Comment 83 Joey Arhar 2020-10-09 20:29:42 PDT

Comment on attachment 411001 [details]
test patch 4

View in context: https://bugs.webkit.org/attachment.cgi?id=411001&action=review

> Source/WebCore/ChangeLog:12
> +        (WebCore::WebGLRenderingContextBase::bindAttribLocation):

12

Comment 84 Joey Arhar 2020-10-10 12:01:10 PDT

Created attachment 411014 [details]
test

Comment 85 Joey Arhar 2020-10-10 12:02:15 PDT

Comment on attachment 411014 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411014&action=review

> Source/WebCore/ChangeLog:1
> +2020-09-25  Kenneth Russell  <kbr@chromium.org>

1

Comment 86 Joey Arhar 2020-10-10 12:02:51 PDT

Comment on attachment 411014 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411014&action=review

> Source/WebCore/ChangeLog:2
> +

2

Comment 87 Joey Arhar 2020-10-10 12:03:35 PDT

Comment on attachment 411014 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411014&action=review

> Source/WebCore/ChangeLog:3
> +        Test bug for code review timeouts

3

Comment 88 Joey Arhar 2020-10-10 12:03:59 PDT

Comment on attachment 411014 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411014&action=review

> Source/WebCore/ChangeLog:4
> +        https://bugs.webkit.org/show_bug.cgi?id=217008

4

Comment 89 Joey Arhar 2020-10-10 12:04:17 PDT

Comment on attachment 411014 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411014&action=review

> Source/WebCore/ChangeLog:5
> +

5

Comment 90 Joey Arhar 2020-10-10 12:05:58 PDT

Comment on attachment 411014 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411014&action=review

> Source/WebCore/ChangeLog:6
> +        Reviewed by NOBODY (OOPS!).

6

Comment 91 Joey Arhar 2020-10-10 12:06:14 PDT

Comment on attachment 411014 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411014&action=review

> Source/WebCore/ChangeLog:7
> +

7

Comment 92 Joey Arhar 2020-10-10 12:06:58 PDT

Comment on attachment 411014 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411014&action=review

> Source/WebCore/ChangeLog:8
> +        No-op changes to have a place for code reviews.

8

Comment 93 Joey Arhar 2020-10-10 12:10:38 PDT

Comment on attachment 411014 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411014&action=review

> Source/WebCore/ChangeLog:9
> +

9

Comment 94 Joey Arhar 2020-10-12 08:54:32 PDT

Created attachment 411121 [details]
test

Comment 95 Joey Arhar 2020-10-12 08:55:30 PDT

Comment on attachment 411121 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411121&action=review

> Source/WebCore/ChangeLog:1
> +2020-09-25  Kenneth Russell  <kbr@chromium.org>

1

Comment 96 Joey Arhar 2020-10-12 08:55:56 PDT

Comment on attachment 411121 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411121&action=review

> Source/WebCore/ChangeLog:2
> +

2

Comment 97 Joey Arhar 2020-10-12 08:56:41 PDT

Comment on attachment 411121 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411121&action=review

> Source/WebCore/ChangeLog:3
> +        Test bug for code review timeouts

3

Comment 98 Joey Arhar 2020-10-12 08:58:12 PDT

Comment on attachment 411121 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411121&action=review

>> Source/WebCore/ChangeLog:3
>> +        Test bug for code review timeouts
> 
> 3

3

> Source/WebCore/ChangeLog:4
> +        https://bugs.webkit.org/show_bug.cgi?id=217008

4

Comment 99 Joey Arhar 2020-10-12 08:59:07 PDT

Comment on attachment 411121 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411121&action=review

>>> Source/WebCore/ChangeLog:3
>>> +        Test bug for code review timeouts
>> 
>> 3
> 
> 3

3

>> Source/WebCore/ChangeLog:4
>> +        https://bugs.webkit.org/show_bug.cgi?id=217008
> 
> 4

4

> Source/WebCore/ChangeLog:5
> +

5

Comment 100 Joey Arhar 2020-10-13 13:29:55 PDT

Created attachment 411246 [details]
test

Comment 101 Joey Arhar 2020-10-13 13:30:11 PDT

Comment on attachment 411246 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411246&action=review

> Source/WebCore/ChangeLog:1
> +2020-09-25  Kenneth Russell  <kbr@chromium.org>

1

Comment 102 Joey Arhar 2020-10-13 13:30:45 PDT

Comment on attachment 411246 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411246&action=review

> Source/WebCore/ChangeLog:2
> +

2

Comment 103 Joey Arhar 2020-10-13 13:31:47 PDT

Comment on attachment 411246 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411246&action=review

> Source/WebCore/ChangeLog:3
> +        Test bug for code review timeouts

3

Comment 104 Joey Arhar 2020-10-13 13:36:05 PDT

Comment on attachment 411246 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411246&action=review

>> Source/WebCore/ChangeLog:3
>> +        Test bug for code review timeouts
> 
> 3

3

> Source/WebCore/ChangeLog:4
> +        https://bugs.webkit.org/show_bug.cgi?id=217008

4

Comment 105 Joey Arhar 2020-10-13 13:46:17 PDT

Comment on attachment 411246 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411246&action=review

> Source/WebCore/ChangeLog:5
> +

5

Comment 106 Joey Arhar 2020-10-13 13:50:15 PDT

Comment on attachment 411246 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411246&action=review

> Source/WebCore/ChangeLog:6
> +        Reviewed by NOBODY (OOPS!).

6

Comment 107 Joey Arhar 2020-10-13 14:03:34 PDT

Comment on attachment 411246 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411246&action=review

> Source/WebCore/ChangeLog:7
> +

7

Comment 108 Joey Arhar 2020-10-13 14:04:15 PDT

Comment on attachment 411246 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411246&action=review

> Source/WebCore/ChangeLog:8
> +        No-op changes to have a place for code reviews.

8

Comment 109 Joey Arhar 2020-10-13 15:25:24 PDT

Created attachment 411268 [details]
test

Comment 110 Joey Arhar 2020-10-13 15:25:55 PDT

Comment on attachment 411268 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411268&action=review

> Source/WebCore/ChangeLog:1
> +2020-09-25  Kenneth Russell  <kbr@chromium.org>

1

Comment 111 Joey Arhar 2020-10-13 15:47:40 PDT

Comment on attachment 411268 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411268&action=review

> Source/WebCore/ChangeLog:2
> +

2

Comment 112 Joey Arhar 2020-10-13 15:48:57 PDT

Comment on attachment 411268 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411268&action=review

> Source/WebCore/ChangeLog:3
> +        Test bug for code review timeouts

3

Comment 113 Joey Arhar 2020-10-13 15:56:28 PDT

Comment on attachment 411268 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411268&action=review

>> Source/WebCore/ChangeLog:3
>> +        Test bug for code review timeouts
> 
> 3

3

> Source/WebCore/ChangeLog:4
> +        https://bugs.webkit.org/show_bug.cgi?id=217008

4

Comment 114 Joey Arhar 2020-10-13 15:57:02 PDT

Comment on attachment 411268 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411268&action=review

>>> Source/WebCore/ChangeLog:3
>>> +        Test bug for code review timeouts
>> 
>> 3
> 
> 3

3

>> Source/WebCore/ChangeLog:4
>> +        https://bugs.webkit.org/show_bug.cgi?id=217008
> 
> 4

4

> Source/WebCore/ChangeLog:5
> +

5

Comment 115 Joey Arhar 2020-10-13 15:58:39 PDT

Comment on attachment 411268 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411268&action=review

> Source/WebCore/ChangeLog:6
> +        Reviewed by NOBODY (OOPS!).

6

Comment 116 Joey Arhar 2020-10-13 16:00:25 PDT

Comment on attachment 411268 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411268&action=review

> Source/WebCore/ChangeLog:7
> +

7

Comment 117 Joey Arhar 2020-10-13 16:01:36 PDT

Comment on attachment 411268 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411268&action=review

> Source/WebCore/ChangeLog:8
> +        No-op changes to have a place for code reviews.

8

Comment 118 Joey Arhar 2020-10-13 16:33:41 PDT

Created attachment 411277 [details]
test

Comment 119 Joey Arhar 2020-10-13 16:34:06 PDT

Comment on attachment 411277 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411277&action=review

> Source/WebCore/ChangeLog:1
> +2020-09-25  Kenneth Russell  <kbr@chromium.org>

1

Comment 120 Joey Arhar 2020-10-13 16:36:59 PDT

Comment on attachment 411277 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411277&action=review

> Source/WebCore/ChangeLog:2
> +

2

Comment 121 Joey Arhar 2020-10-13 16:37:57 PDT

Comment on attachment 411277 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411277&action=review

> Source/WebCore/ChangeLog:3
> +        Test bug for code review timeouts

3

Comment 122 Joey Arhar 2020-10-13 16:38:55 PDT

Comment on attachment 411277 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411277&action=review

> Source/WebCore/ChangeLog:4
> +        https://bugs.webkit.org/show_bug.cgi?id=217008

4

Comment 123 Joey Arhar 2020-10-13 16:43:20 PDT

Comment on attachment 411277 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411277&action=review

> Source/WebCore/ChangeLog:5
> +

5

Comment 124 Joey Arhar 2020-10-13 16:54:12 PDT

Comment on attachment 411277 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411277&action=review

> Source/WebCore/ChangeLog:6
> +        Reviewed by NOBODY (OOPS!).

6

Comment 125 Joey Arhar 2020-10-13 16:55:05 PDT

Comment on attachment 411277 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411277&action=review

> Source/WebCore/ChangeLog:7
> +

7

Comment 126 Joey Arhar 2020-10-13 17:30:23 PDT

Created attachment 411284 [details]
test

Comment 127 Joey Arhar 2020-10-13 17:31:05 PDT

Comment on attachment 411284 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review

> Source/WebCore/ChangeLog:1
> +2020-09-25  Kenneth Russell  <kbr@chromium.org>

1

Comment 128 Joey Arhar 2020-10-13 17:32:21 PDT

Comment on attachment 411284 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review

>> Source/WebCore/ChangeLog:1
>> +2020-09-25  Kenneth Russell  <kbr@chromium.org>
> 
> 1

1

> Source/WebCore/ChangeLog:2
> +

2

Comment 129 Joey Arhar 2020-10-13 17:34:07 PDT

Comment on attachment 411284 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review

> Source/WebCore/ChangeLog:3
> +        Test bug for code review timeouts

3

Comment 130 Joey Arhar 2020-10-13 17:34:26 PDT

Comment on attachment 411284 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review

> Source/WebCore/ChangeLog:4
> +        https://bugs.webkit.org/show_bug.cgi?id=217008

4

Comment 131 Joey Arhar 2020-10-13 17:35:17 PDT

Comment on attachment 411284 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review

> Source/WebCore/ChangeLog:5
> +

5

Comment 132 Joey Arhar 2020-10-13 17:35:36 PDT

Comment on attachment 411284 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review

> Source/WebCore/ChangeLog:6
> +        Reviewed by NOBODY (OOPS!).

6

Comment 133 Joey Arhar 2020-10-13 17:36:21 PDT

Comment on attachment 411284 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review

> Source/WebCore/ChangeLog:7
> +

7

Comment 134 Joey Arhar 2020-10-13 17:36:43 PDT

Comment on attachment 411284 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review

> Source/WebCore/ChangeLog:8
> +        No-op changes to have a place for code reviews.

8

Comment 135 Joey Arhar 2020-10-13 17:37:27 PDT

Comment on attachment 411284 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review

> Source/WebCore/ChangeLog:9
> +

9

Comment 136 Joey Arhar 2020-10-13 17:38:17 PDT

Comment on attachment 411284 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review

> Source/WebCore/ChangeLog:10
> +        * html/canvas/WebGLRenderingContextBase.cpp:

10

Comment 137 Joey Arhar 2020-10-13 17:38:36 PDT

Comment on attachment 411284 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review

> Source/WebCore/ChangeLog:11
> +        (WebCore::WebGLRenderingContextBase::initializeNewContext):

11

Comment 138 Joey Arhar 2020-10-13 17:39:44 PDT

Comment on attachment 411284 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review

> Source/WebCore/ChangeLog:12
> +        (WebCore::WebGLRenderingContextBase::bindAttribLocation):

12

Comment 139 Joey Arhar 2020-10-13 17:39:59 PDT

Comment on attachment 411284 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review

> Source/WebCore/ChangeLog:13
> +        (WebCore::WebGLRenderingContextBase::createFramebuffer):

13

Comment 140 Joey Arhar 2020-10-13 17:40:43 PDT

Comment on attachment 411284 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review

> Source/WebCore/ChangeLog:14
> +        (WebCore::WebGLRenderingContextBase::drawArrays):

14

Comment 141 Joey Arhar 2020-10-13 17:41:01 PDT

Comment on attachment 411284 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review

> Source/WebCore/ChangeLog:15
> +        (WebCore::WebGLRenderingContextBase::getUniformLocation):

15

Comment 142 Joey Arhar 2020-10-13 17:41:44 PDT

Comment on attachment 411284 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review

> Source/WebCore/ChangeLog:16
> +        (WebCore::WebGLRenderingContextBase::readPixels):

16

Comment 143 Joey Arhar 2020-10-13 17:42:32 PDT

Comment on attachment 411284 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review

> Source/WebCore/ChangeLog:17
> +        (WebCore::WebGLRenderingContextBase::texSubImage2DBase):

17

Comment 144 Joey Arhar 2020-10-13 17:43:15 PDT

Comment on attachment 411284 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review

> Source/WebCore/ChangeLog:18
> +        (WebCore::WebGLRenderingContextBase::texParameter):

18

Comment 145 Joey Arhar 2020-10-13 17:43:34 PDT

Comment on attachment 411284 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review

> Source/WebCore/ChangeLog:19
> +

19

Comment 146 Joey Arhar 2020-10-13 17:44:14 PDT

Comment on attachment 411284 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review

> Source/WebCore/ChangeLog:20
>  2020-09-23  Chris Dumez  <cdumez@apple.com>

20

Comment 147 Joey Arhar 2020-10-13 17:44:35 PDT

Comment on attachment 411284 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review

> Source/WebCore/ChangeLog:21
>  

21

Comment 148 Joey Arhar 2020-10-13 17:45:20 PDT

Comment on attachment 411284 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review

> Source/WebCore/ChangeLog:22
>          webaudio/AudioBufferSource/audiobuffersource-playbackrate.html is crashing

22

Comment 149 Joey Arhar 2020-10-13 17:46:08 PDT

Comment on attachment 411284 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:844
>  

23

Comment 150 Joey Arhar 2020-10-13 17:47:38 PDT

Comment on attachment 411284 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:845
>  void WebGLRenderingContextBase::initializeNewContext()

24

Comment 151 Joey Arhar 2020-10-13 17:47:56 PDT

Comment on attachment 411284 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:846
>  {

25

Comment 152 Joey Arhar 2020-10-13 17:48:32 PDT

Comment on attachment 411284 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:847
> +    //

26

Comment 153 Joey Arhar 2020-10-13 17:48:47 PDT

Comment on attachment 411284 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:848
> +    //

27

Comment 154 Joey Arhar 2020-10-13 17:49:20 PDT

Comment on attachment 411284 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:849
> +    // TESTING

28

Comment 155 Joey Arhar 2020-10-13 19:37:03 PDT

Comment on attachment 411284 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:850
> +    //

29

Comment 156 Joey Arhar 2020-10-13 19:38:19 PDT

Comment on attachment 411284 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review

>> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:850
>> +    //
> 
> 29

29

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:851
> +    //

30

Comment 157 Richard Townsend 2020-10-14 02:46:22 PDT

Comment on attachment 411284 [details]
test

Testing

Comment 158 Richard Townsend 2020-10-14 02:47:56 PDT

Comment on attachment 411284 [details]
test

Testing

Comment 159 Richard Townsend 2020-10-14 02:48:37 PDT

Comment on attachment 411284 [details]
test

Testing

Comment 160 Richard Townsend 2020-10-14 02:59:12 PDT

Comment on attachment 411284 [details]
test

Testing

Comment 161 Richard Townsend 2020-10-14 03:12:51 PDT

Comment on attachment 411284 [details]
test

Testing

Comment 162 Richard Townsend 2020-10-14 03:45:58 PDT

Comment on attachment 411284 [details]
test

Testing

Comment 163 Richard Townsend 2020-10-14 03:49:07 PDT

Comment on attachment 411284 [details]
test

Testing

Comment 164 Joey Arhar 2020-10-14 10:17:59 PDT

Comment on attachment 411284 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review

>>> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:850
>>> +    //
>> 
>> 29
> 
> 29

29

>> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:851
>> +    //
> 
> 30

30

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:852
> +

31

Comment 165 Joey Arhar 2020-10-14 10:18:23 PDT

Comment on attachment 411284 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:853
>      ASSERT(!m_contextLost);

32

Comment 166 Joey Arhar 2020-10-14 10:33:37 PDT

Comment on attachment 411284 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review

>> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:853
>>      ASSERT(!m_contextLost);
> 
> 32

32

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:854
>      m_needsUpdate = true;

33

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:855
>      m_markedCanvasDirty = false;

34

Comment 167 Joey Arhar 2020-10-14 12:06:19 PDT

Comment on attachment 411284 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review

>>> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:853
>>>      ASSERT(!m_contextLost);
>> 
>> 32
> 
> 32

32

>> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:854
>>      m_needsUpdate = true;
> 
> 33

33

>> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:855
>>      m_markedCanvasDirty = false;
> 
> 34

34

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1349
>  

35

Comment 168 Joey Arhar 2020-10-14 12:11:12 PDT

Comment on attachment 411284 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1350
>  void WebGLRenderingContextBase::bindAttribLocation(WebGLProgram& program, GCGLuint index, const String& name)

36

Comment 169 Joey Arhar 2020-10-15 14:59:25 PDT

Comment on attachment 411284 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1351
>  {

37

Comment 170 Joey Arhar 2020-10-15 15:00:17 PDT

Comment on attachment 411284 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1352
> +    //

38

Comment 171 Joey Arhar 2020-10-15 15:02:53 PDT

Comment on attachment 411284 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1353
> +    //

39

Comment 172 Joey Arhar 2020-10-15 17:33:35 PDT

Comment on attachment 411284 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review

>> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1353
>> +    //
> 
> 39

39

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1354
> +    // TESTING

40

Comment 173 Joey Arhar 2020-10-15 17:36:01 PDT

Comment on attachment 411284 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review

>>> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1353
>>> +    //
>> 
>> 39
> 
> 39

39

>> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1354
>> +    // TESTING
> 
> 40

40

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1355
> +    //

41

Comment 174 Joey Arhar 2020-10-15 17:37:21 PDT

Comment on attachment 411284 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review

>>>> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1353
>>>> +    //
>>> 
>>> 39
>> 
>> 39
> 
> 39

39

>>> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1354
>>> +    // TESTING
>> 
>> 40
> 
> 40

40

>> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1355
>> +    //
> 
> 41

41

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1356
> +    //

42

Comment 175 Joey Arhar 2020-10-15 17:38:12 PDT

Comment on attachment 411284 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1357
> +

43

Comment 176 Richard Townsend 2020-10-19 17:03:24 PDT

Comment on attachment 411284 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review

Testing

>>>> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1354
>>>> +    // TESTING
>>> 
>>> 40
>> 
>> 40
> 
> 40

Testing

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:4208
> +    //

Testing

Comment 177 Richard Townsend 2020-10-19 17:07:08 PDT

Comment on attachment 411284 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review

TEsting

>> Source/WebCore/ChangeLog:17
>> +        (WebCore::WebGLRenderingContextBase::texSubImage2DBase):
> 
> 17

Testing

>>>>> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1354
>>>>> +    // TESTING
>>>> 
>>>> 40
>>> 
>>> 40
>> 
>> 40
> 
> Testing

Testing

>> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:4208
>> +    //
> 
> Testing

Testing

Comment 178 Joey Arhar 2020-10-19 18:37:15 PDT

Comment on attachment 411284 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1358
>      if (isContextLostOrPending() || !validateWebGLProgramOrShader("bindAttribLocation", &program))

44

Comment 179 Richard Townsend 2020-10-20 08:06:04 PDT

Comment on attachment 411284 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review

TEsting

>>> Source/WebCore/ChangeLog:17
>>> +        (WebCore::WebGLRenderingContextBase::texSubImage2DBase):
>> 
>> 17
> 
> Testing

Testing

>>>>>> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1354
>>>>>> +    // TESTING
>>>>> 
>>>>> 40
>>>> 
>>>> 40
>>> 
>>> 40
>> 
>> Testing
> 
> Testing

Testing

>>> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1355
>>> +    //
>> 
>> 41
> 
> 41

Testing

>>> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:4208
>>> +    //
>> 
>> Testing
> 
> Testing

Testing

Comment 180 Richard Townsend 2020-10-20 08:43:35 PDT

Comment on attachment 411268 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411268&action=review

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1359
>          return;

Testing.

Comment 181 Richard Townsend 2020-10-20 08:46:15 PDT

Comment on attachment 411284 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:2558
> +    //

Testing

Comment 182 Richard Townsend 2020-10-20 08:47:23 PDT

Comment on attachment 411268 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411268&action=review

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:853
>      ASSERT(!m_contextLost);

Test

Comment 183 Richard Townsend 2020-10-20 08:52:42 PDT

Comment on attachment 411001 [details]
test patch 4

View in context: https://bugs.webkit.org/attachment.cgi?id=411001&action=review

> Source/WebCore/ChangeLog:18
> +        (WebCore::WebGLRenderingContextBase::texParameter):

Testing

Comment 184 Richard Townsend 2020-10-20 08:53:16 PDT

Comment on attachment 411284 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review

Testing

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:4209
> +

Testing

Comment 185 Richard Townsend 2020-10-20 08:54:03 PDT

Comment on attachment 411284 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review

Testing.

>>>> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1355
>>>> +    //
>>> 
>>> 41
>> 
>> 41
> 
> Testing

Testing.

Comment 186 Richard Townsend 2020-10-20 08:59:53 PDT

Comment on attachment 411284 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review

>>> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:855
>>>      m_markedCanvasDirty = false;
>> 
>> 34
> 
> 34

Testing

Comment 187 Richard Townsend 2020-10-20 09:01:10 PDT

Comment on attachment 411268 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411268&action=review

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:849
> +    // TESTING

testing

>> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:853
>>      ASSERT(!m_contextLost);
> 
> Test

c

Comment 188 Richard Townsend 2020-10-20 09:06:48 PDT

Comment on attachment 411268 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411268&action=review

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:851
> +    //

Testing

Comment 189 Richard Townsend 2020-10-20 09:07:14 PDT

Comment on attachment 411268 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411268&action=review

>>> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:853
>>>      ASSERT(!m_contextLost);
>> 
>> Test
> 
> c

Testing

Comment 190 Richard Townsend 2020-10-20 09:08:29 PDT

Comment on attachment 411014 [details]
test

Testing

Comment 191 Richard Townsend 2020-10-20 09:09:42 PDT

Comment on attachment 411268 [details]
test

Testing

Comment 192 Richard Townsend 2020-10-20 09:15:23 PDT

Comment on attachment 411284 [details]
test

Testing

Comment 193 Richard Townsend 2020-10-20 09:16:21 PDT

Comment on attachment 409932 [details]
test patch

Testing

Comment 194 Richard Townsend 2020-10-20 09:27:28 PDT

Comment on attachment 411014 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411014&action=review

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:4207
> +    //

Testing

Comment 195 Richard Townsend 2020-10-20 09:27:35 PDT

View in context: https://bugs.webkit.org/attachment.cgi?id=411014&action=review

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:4207
> +    //

Testing

Comment 196 Richard Townsend 2020-10-20 09:28:46 PDT

Comment on attachment 411268 [details]
test

Something

Comment 197 Richard Townsend 2020-10-20 09:30:31 PDT

Comment on attachment 409934 [details]
test patch upload 3

Testing

Comment 198 Richard Townsend 2020-10-20 09:33:47 PDT

Comment on attachment 409934 [details]
test patch upload 3

View in context: https://bugs.webkit.org/attachment.cgi?id=409934&action=review

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:852
> +

Testing

Comment 199 Richard Townsend 2020-10-20 09:35:15 PDT

Comment on attachment 411268 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411268&action=review

Testing

> Source/WebCore/ChangeLog:16
> +        (WebCore::WebGLRenderingContextBase::readPixels):

Testing

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:2554
> +    //

Tetsting

Comment 200 Richard Townsend 2020-10-20 09:57:06 PDT

Comment on attachment 411284 [details]
test

asdf

Comment 201 Richard Townsend 2020-10-20 10:09:05 PDT

Comment on attachment 411284 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:4207
> +    //

Testing

Comment 202 Richard Townsend 2020-10-20 10:22:19 PDT

Comment on attachment 411284 [details]
test

asdfasdf

Comment 203 Richard Townsend 2020-10-20 10:23:13 PDT

Comment on attachment 411284 [details]
test

Testing

Comment 204 Richard Townsend 2020-10-20 10:26:26 PDT

Comment on attachment 409934 [details]
test patch upload 3

View in context: https://bugs.webkit.org/attachment.cgi?id=409934&action=review

Testing

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1356
> +    //

Testing

Comment 205 Richard Townsend 2020-10-20 10:27:51 PDT

Comment on attachment 411284 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1961
> +

Testing

Comment 206 Richard Townsend 2020-10-20 10:33:05 PDT

Comment on attachment 409933 [details]
test patch upload 2

Testing

Comment 207 Richard Townsend 2020-10-20 10:35:40 PDT

Comment on attachment 409933 [details]
test patch upload 2

Testing

Comment 208 Richard Townsend 2020-10-20 10:41:43 PDT

Comment on attachment 411268 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411268&action=review

Test

> Source/WebCore/ChangeLog:21
>  

Test

Comment 209 Richard Townsend 2020-10-20 10:53:03 PDT

Comment on attachment 411284 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review

>>>> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:853
>>>>      ASSERT(!m_contextLost);
>>> 
>>> 32
>> 
>> 32
> 
> 32

Testing

Comment 210 Richard Townsend 2020-10-20 10:57:11 PDT

Comment on attachment 409932 [details]
test patch

Testing

Comment 211 Richard Townsend 2020-10-20 10:57:43 PDT

Comment on attachment 411284 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review

Testing

>> Source/WebCore/ChangeLog:16
>> +        (WebCore::WebGLRenderingContextBase::readPixels):
> 
> 16

Testing

Comment 212 Richard Townsend 2020-10-20 10:58:57 PDT

Comment on attachment 411284 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review

Testing

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:5065
> +    //

Testing

Comment 213 Richard Townsend 2020-10-20 11:49:45 PDT

Comment on attachment 411284 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review

>>> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:851
>>> +    //
>> 
>> 30
> 
> 30

Testing

Comment 214 Richard Townsend 2020-10-21 11:24:43 PDT

Comment on attachment 411277 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411277&action=review

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1356
> +    //

Testing

Comment 215 Richard Townsend 2020-10-21 11:25:53 PDT

Comment on attachment 411121 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411121&action=review

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1960
> +    //

Testing

Comment 216 Richard Townsend 2020-10-21 15:20:38 PDT

Comment on attachment 411014 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411014&action=review

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:850
> +    //

Testing

Comment 217 Joey Arhar 2020-10-22 15:55:30 PDT

Comment on attachment 411284 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review

>> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1350
>>  void WebGLRenderingContextBase::bindAttribLocation(WebGLProgram& program, GCGLuint index, const String& name)
> 
> 36

36

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1359
>          return;

45

Comment 218 Joey Arhar 2020-10-22 15:57:38 PDT

Comment on attachment 411284 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1360
>      if (!validateLocationLength("bindAttribLocation", name))

46

Comment 219 Mason Freed 2020-10-28 15:41:56 PDT

Comment on attachment 409897 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409897&action=review

test

> Source/WebCore/ChangeLog:8
> +        No-op changes to have a place for code reviews.

testing 123

Comment 220 Mason Freed 2020-10-28 17:18:32 PDT

Comment on attachment 409897 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409897&action=review

test

>> Source/WebCore/ChangeLog:8
>> +        No-op changes to have a place for code reviews.
> 
> testing 123

testing 123

> Source/WebCore/ChangeLog:9
> +

testing again