Bug 216939 - Use more inline initialization and constexpr in WebAudio code
Summary: Use more inline initialization and constexpr in WebAudio code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Audio (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 212611
  Show dependency tree / graph
 
Reported: 2020-09-24 12:06 PDT by Chris Dumez
Modified: 2020-09-24 13:11 PDT (History)
10 users (show)

See Also:

Attachments
Patch (70.49 KB, patch)
2020-09-24 12:11 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (72.56 KB, patch)
2020-09-24 12:31 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2020-09-24 12:06:55 PDT 
Use more inline initialization and constexpr in WebAudio code.
Comment 1 Chris Dumez 2020-09-24 12:11:23 PDT 
Created attachment 409610 [details]
Patch
Comment 2 Darin Adler 2020-09-24 12:24:44 PDT 
Comment on attachment 409610 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409610&action=review

> Source/WebCore/platform/audio/HRTFPanner.h:85
> +    int m_azimuthIndex1 { UninitializedAzimuth };

Maybe these become optionals too?

> Source/WebCore/platform/audio/HRTFPanner.h:89
> +    int m_azimuthIndex2 { UninitializedAzimuth };

Maybe these become optionals too?
Comment 3 Chris Dumez 2020-09-24 12:31:54 PDT 
Created attachment 409612 [details]
Patch
Comment 4 EWS 2020-09-24 13:10:11 PDT 
Committed r267544: <https://trac.webkit.org/changeset/267544>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 409612 [details].
Comment 5 Radar WebKit Bug Importer 2020-09-24 13:11:16 PDT 
<rdar://problem/69521117>