Bug 216889 - Notify igalia team about pre-existing test failures and build failures for JSC queues
Summary: Notify igalia team about pre-existing test failures and build failures for JS...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-09-23 11:14 PDT by Aakash Jain
Modified: 2020-11-09 20:32 PST (History)
7 users (show)

See Also:

Attachments
Patch (4.45 KB, patch)
2020-09-23 11:17 PDT, Aakash Jain 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2020-09-23 11:14:04 PDT 
Notify igalia team about pre-existing test failures and build failures for JSC queues.
Comment 1 Aakash Jain 2020-09-23 11:17:49 PDT 
Created attachment 409487 [details]
Patch
Comment 2 Jonathan Bedard 2020-09-23 11:19:18 PDT 
Comment on attachment 409487 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409487&action=review

> Tools/BuildSlaveSupport/ews-build/emails.json:10
> +      "jsc32@igalia.com"

Looks fine, but I would like someone from Igalia to verify they want this before we land it.
Comment 3 Jonathan Bedard 2020-09-23 11:54:37 PDT 
(In reply to Jonathan Bedard from comment #2)
> Comment on attachment 409487 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=409487&action=review
> 
> > Tools/BuildSlaveSupport/ews-build/emails.json:10
> > +      "jsc32@igalia.com"
> 
> Looks fine, but I would like someone from Igalia to verify they want this
> before we land it.

Looks like Igalia already verified in Slack that they want this.
Comment 4 EWS 2020-09-23 12:07:14 PDT 
Committed r267492: <https://trac.webkit.org/changeset/267492>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 409487 [details].
Comment 5 Radar WebKit Bug Importer 2020-09-23 12:08:17 PDT 
<rdar://problem/69450105>
Comment 6 Guillaume Emont 2020-09-23 12:34:53 PDT 
Comment on attachment 409487 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409487&action=review

>>> Tools/BuildSlaveSupport/ews-build/emails.json:10
>>> +      "jsc32@igalia.com"
>> 
>> Looks fine, but I would like someone from Igalia to verify they want this before we land it.
> 
> Looks like Igalia already verified in Slack that they want this.

Don't know if there's better naming to be had, but technically, that's not the whole jsc team, but only the ones working on embedded/32-bit things. We also have people doing feature work who are not included in that email. Maybe I'm being too pedantic though ;).
Comment 7 Aakash Jain 2020-09-23 12:44:41 PDT 
(In reply to Guillaume Emont from comment #6)
> Don't know if there's better naming to be had, but technically, that's not the whole jsc team, but only the ones working on embedded/32-bit things. We also have people doing feature work who are not included in that email. Maybe I'm being too pedantic though ;).
I guess specific name doesn't matter so much here. Feel free to change it to a better name though.
Comment 8 Aakash Jain 2020-09-23 13:01:57 PDT 
Restarted buildbot to pick up this change.