Bug 216826 - [iOS] In case of live media capture, activate capture icon
Summary: [iOS] In case of live media capture, activate capture icon
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-09-22 08:44 PDT by youenn fablet
Modified: 2020-09-29 06:00 PDT (History)
8 users (show)

See Also:

Attachments
WIP (52.06 KB, patch)
2020-09-28 09:27 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
WIP (37.64 KB, patch)
2020-09-28 11:47 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (43.89 KB, patch)
2020-09-29 05:34 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (43.84 KB, patch)
2020-09-29 05:51 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (43.94 KB, patch)
2020-09-29 06:00 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2020-09-22 08:44:45 PDT 
[iOS] In case of live media capture, activate capture icon
Comment 1 youenn fablet 2020-09-28 09:27:28 PDT 
Created attachment 409890 [details]
WIP
Comment 2 Eric Carlson 2020-09-28 11:06:08 PDT 
Comment on attachment 409890 [details]
WIP

View in context: https://bugs.webkit.org/attachment.cgi?id=409890&action=review

> Source/WebKit/NetworkProcess/ServiceWorker/ServiceWorkerDownloadTask.cpp:41
> +ServiceWorkerDownloadTask::ServiceWorkerDownloadTask(WebSWServerConnection& connection, WebCore::FetchIdentifier fetchIdentifier, ServiceWorkerIdentifier serviceWorkerIdentifier, ServiceWorkerRegistrationIdentifier serviceWorkerRegistrationIdentifier, PendingDownload& download, DownloadID downloadID, const WebCore::ResourceRequest& request, const WebCore::ResourceResponse& response)

Did you mean to include this file?

> Source/WebKit/NetworkProcess/ServiceWorker/ServiceWorkerDownloadTask.h:47
> +class ServiceWorkerDownloadTask : public CanMakeWeakPtr<ServiceWorkerDownloadTask> {

Ditto.

> Source/WebKit/UIProcess/Cocoa/WKMediaCaptureStatusBarManager.mm:188
> +    RELEASE_LOG_ERROR(WebRTC, "WKMediaCaptureStatusBarManagerSource/WebCore/PAL/pal/cf/SpringBoardServicesSoftLink.h  did invalidate status bar");

I don't think you meant to include the path in the logging output.

> Source/WebKit/WebProcess/GPU/media/AudioOutputProvider.cpp:34
> +void AudioOutputProvider::defaultAudioOutputDeviceChanged(Page& page)

Oops, you probably didn't mean to include this.

> Source/WebKit/WebProcess/GPU/media/AudioOutputProvider.h:32
> +class AudioOutputProvider : public WebCore::AudioOutputProvider {

Ditto.
Comment 3 youenn fablet 2020-09-28 11:47:01 PDT 
Created attachment 409907 [details]
WIP
Comment 4 youenn fablet 2020-09-29 05:34:44 PDT 
Created attachment 409986 [details]
Patch
Comment 5 Radar WebKit Bug Importer 2020-09-29 05:39:13 PDT 
<rdar://problem/69744048>
Comment 6 youenn fablet 2020-09-29 05:51:40 PDT 
Created attachment 409990 [details]
Patch
Comment 7 youenn fablet 2020-09-29 06:00:09 PDT 
Created attachment 409991 [details]
Patch