Bug 216760 - [JSC] Intl spec update: handle awkward rounding behavior
Summary: [JSC] Intl spec update: handle awkward rounding behavior
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks: 213425
  Show dependency tree / graph
 
Reported: 2020-09-20 22:09 PDT by Yusuke Suzuki
Modified: 2020-09-23 14:27 PDT (History)
8 users (show)

See Also:

Attachments
Patch (14.11 KB, patch)
2020-09-20 22:45 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (14.32 KB, patch)
2020-09-20 22:51 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (15.75 KB, patch)
2020-09-23 12:04 PDT, Yusuke Suzuki 		ross.kirsling: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2020-09-20 22:09:02 PDT 
https://github.com/tc39/ecma402/pull/471
Comment 1 Yusuke Suzuki 2020-09-20 22:45:36 PDT 
Created attachment 409260 [details]
Patch
Comment 2 Yusuke Suzuki 2020-09-20 22:51:35 PDT 
Created attachment 409261 [details]
Patch
Comment 3 Yusuke Suzuki 2020-09-23 12:04:16 PDT 
Created attachment 409494 [details]
Patch
Comment 4 Yusuke Suzuki 2020-09-23 12:04:30 PDT 
Comment on attachment 409494 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409494&action=review

> JSTests/test262/expectations.yaml:1475
> +  strict mode: 'Test262Error: Expected a RangeError to be thrown but no exception was thrown at all'

Test262 update https://github.com/tc39/test262/pull/2817
Comment 5 Ross Kirsling 2020-09-23 12:09:12 PDT 
Comment on attachment 409494 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409494&action=review

r=me, based on the understanding that test262 will be fixed soon.

> JSTests/stress/intl-numberformat.js:464
> +    let nf = new Intl.NumberFormat('en', {

I'd be inclined to ask for a test using a different locale but I guess this issue is more about options than locale anyway.
Comment 6 Yusuke Suzuki 2020-09-23 14:26:14 PDT 
Committed r267500: <https://trac.webkit.org/changeset/267500>
Comment 7 Radar WebKit Bug Importer 2020-09-23 14:27:19 PDT 
<rdar://problem/69457838>