Bug 216738 - Change render tree selection painting code to use non-canonicalized points
Summary: Change render tree selection painting code to use non-canonicalized points
Status: ASSIGNED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Darin Adler
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-09-19 18:38 PDT by Darin Adler
Modified: 2020-09-26 18:39 PDT (History)
4 users (show)

See Also:

Attachments
Patch (6.84 KB, patch)
2020-09-19 18:42 PDT, Darin Adler 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2020-09-19 18:38:34 PDT 
Selection API: Remove unneeded incorrect code that overwrites the base and extent of a selection based on visibility
Comment 1 Darin Adler 2020-09-19 18:42:33 PDT 
Created attachment 409220 [details]
Patch
Comment 2 Darin Adler 2020-09-20 14:36:11 PDT 
OK, turns out I misunderstood the code here. It’s calling a setSelection function on the render tree, which should not have any effect on the selection in the DOM. But somehow it did have an effect. Need to restore the old code and figure out what was happening.
Comment 3 Darin Adler 2020-09-20 21:42:14 PDT 
Not sure I need to do this any time soon. It’s nice to improve how we tie painting the selection to the DOM to not rely on so much editing strangeness. But not needed for the Selection API project.
Comment 4 Radar WebKit Bug Importer 2020-09-26 18:39:15 PDT 
<rdar://problem/69639857>