Bug 216608 - Remove the legacy animation code
Summary: Remove the legacy animation code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Animations (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-09-16 07:11 PDT by Antoine Quint
Modified: 2020-10-01 12:17 PDT (History)
25 users (show)

See Also:

Attachments
Patch (536.37 KB, patch)
2020-09-16 07:20 PDT, Antoine Quint 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (539.79 KB, patch)
2020-09-16 07:35 PDT, Antoine Quint 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (545.48 KB, patch)
2020-09-16 09:40 PDT, Antoine Quint 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (545.13 KB, patch)
2020-09-16 10:06 PDT, Antoine Quint 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (546.52 KB, patch)
2020-09-16 11:38 PDT, Antoine Quint 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (515.80 KB, patch)
2020-09-16 12:22 PDT, Antoine Quint 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (521.35 KB, patch)
2020-09-16 12:56 PDT, Antoine Quint 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (521.74 KB, patch)
2020-09-16 13:40 PDT, Antoine Quint 		no flags Details | Formatted Diff | Diff
Patch (520.47 KB, patch)
2020-09-17 03:48 PDT, Antoine Quint 		no flags Details | Formatted Diff | Diff
Patch (520.73 KB, patch)
2020-09-17 04:12 PDT, Antoine Quint 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (9) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2020-09-16 07:11:06 PDT 
Remove the legacy animation code
Comment 1 Antoine Quint 2020-09-16 07:20:01 PDT 
Created attachment 408920 [details]
Patch
Comment 2 Antoine Quint 2020-09-16 07:35:30 PDT 
Created attachment 408921 [details]
Patch
Comment 3 Antoine Quint 2020-09-16 08:51:19 PDT 
Looks like I broke computed style for transform and filter, both accelerated properties.
Comment 4 Antoine Quint 2020-09-16 09:40:16 PDT 
Created attachment 408928 [details]
Patch
Comment 5 Antoine Quint 2020-09-16 10:06:44 PDT 
Created attachment 408931 [details]
Patch
Comment 6 Antoine Quint 2020-09-16 10:07:16 PDT 
Filed bug 216612 to look into the GTK / WPE build failures which seem to be a bug in the code generation for IDL files.
Comment 7 Antoine Quint 2020-09-16 11:38:13 PDT 
Created attachment 408938 [details]
Patch
Comment 8 Antoine Quint 2020-09-16 12:22:28 PDT 
Created attachment 408941 [details]
Patch
Comment 9 Antoine Quint 2020-09-16 12:56:56 PDT 
Created attachment 408945 [details]
Patch
Comment 10 Antoine Quint 2020-09-16 13:40:04 PDT 
Created attachment 408952 [details]
Patch
Comment 11 Antoine Quint 2020-09-17 03:48:01 PDT 
Created attachment 409018 [details]
Patch
Comment 12 Antoine Quint 2020-09-17 04:12:44 PDT 
Created attachment 409020 [details]
Patch
Comment 13 Antoine Quint 2020-09-17 05:25:29 PDT 
The test failures on the Windows bots don't seem related to this patch. A local Windows build manages to pass animation tests that otherwise showed as a Crash.

Note that the Windows build required a manual clean build on the bot to succeed. Same goes for WPE and GTK builds, though I managed to get the EWS bots to build by making a dummy change to ShadowRoot.idl. This is covered by bug 216612.

Going to land the patch as I believe it to be OK with the caveats listed above.
Comment 14 Antoine Quint 2020-09-17 05:39:40 PDT 
Committed r267188: <https://trac.webkit.org/changeset/267188>
Comment 15 Radar WebKit Bug Importer 2020-09-17 05:40:18 PDT 
<rdar://problem/69063339>