Bug 216605 - Disable playsInline requirement for MediaStream backed videos
Summary: Disable playsInline requirement for MediaStream backed videos
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-09-16 02:11 PDT by youenn fablet
Modified: 2020-09-23 02:15 PDT (History)
14 users (show)

See Also:


Attachments
Patch (1.89 KB, patch)
2020-09-16 02:16 PDT, youenn fablet
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (2.89 KB, patch)
2020-09-16 03:24 PDT, youenn fablet
no flags Details | Formatted Diff | Diff
Patch (4.53 KB, patch)
2020-09-16 08:56 PDT, youenn fablet
ews-feeder: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2020-09-16 02:11:58 PDT
Disable playsInline requirement for MediaStream backed videos
Comment 1 youenn fablet 2020-09-16 02:16:20 PDT
Created attachment 408907 [details]
Patch
Comment 2 youenn fablet 2020-09-16 03:24:13 PDT
Created attachment 408909 [details]
Patch
Comment 3 youenn fablet 2020-09-16 08:56:57 PDT
Created attachment 408925 [details]
Patch
Comment 4 Alexey Proskuryakov 2020-09-16 13:31:09 PDT
Comment on attachment 408925 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408925&action=review

> Source/WebCore/ChangeLog:3
> +        Disable playsInline requirement for MediaStream backed videos

Would that provide a way to work around intentional limitations, and to make user experience inconsistent?
Comment 5 youenn fablet 2020-09-17 04:43:56 PDT
> > Source/WebCore/ChangeLog:3
> > +        Disable playsInline requirement for MediaStream backed videos
> 
> Would that provide a way to work around intentional limitations, and to make
> user experience inconsistent?

Carefully designed websites can set playsInline to false or true as desired.
Some websites forgot to include playsInline and do not work on iOS. This is not intentional, just the fact that this is specific to Safari on iOS.

We could go with Quirks.
In the long run though, it seems better and simpler to align with other browsers, and progressively deprecate playsInline. Hence this patch.
Comment 6 Radar WebKit Bug Importer 2020-09-23 02:15:15 PDT
<rdar://problem/69423348>