Bug 216568 - run-webkit-tests runs xcodebuild an unnecessary amount of times
Summary: run-webkit-tests runs xcodebuild an unnecessary amount of times
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kimmo Kinnunen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-09-15 10:09 PDT by Tim Horton
Modified: 2022-07-27 18:17 PDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2020-09-15 10:09:05 PDT 
PlatformInfo tries to memoize calls to xcodebuild to determine SDKs and Xcode version, but there isn't a singleton PlatformInfo, so it doesn't work.

Fixing this reduces the time to run a single test from ~7 seconds to ~3.
Comment 1 Radar WebKit Bug Importer 2020-09-22 10:10:18 PDT 
<rdar://problem/69377368>
Comment 2 Kimmo Kinnunen 2022-06-30 04:05:11 PDT 
https://github.com/WebKit/WebKit/pull/1941
Comment 3 Tim Horton 2022-06-30 10:44:47 PDT 
kimmo++, thank you for fixing :)
Comment 4 EWS 2022-07-01 09:35:09 PDT 
Committed 252047@main (bac2308618bb): <https://commits.webkit.org/252047@main>

Reviewed commits have been landed. Closing PR #1941 and removing active labels.