Bug 216441 - [WebIDL] Remove need for [MayThrowException] on indexed and named setters
Summary: [WebIDL] Remove need for [MayThrowException] on indexed and named setters
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords: InRadar
Depends on:
Blocks: 180019
  Show dependency tree / graph
 
Reported: 2020-09-12 11:42 PDT by Sam Weinig
Modified: 2020-09-13 11:14 PDT (History)
17 users (show)

See Also:

Attachments
Patch (52.55 KB, patch)
2020-09-12 11:47 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (52.52 KB, patch)
2020-09-13 10:30 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2020-09-12 11:42:21 PDT 
[WebIDL] Remove need for [MayThrowException] on indexed and named setters
Comment 1 Sam Weinig 2020-09-12 11:47:38 PDT 
Created attachment 408603 [details]
Patch
Comment 2 Darin Adler 2020-09-12 14:23:36 PDT 
Comment on attachment 408603 [details]
Patch

Kinda wish there was a way to record the requirement that something *not* throw an exception, but if WebIDL doesn’t include that, then I guess we don’t need to innovate.
Comment 3 EWS 2020-09-12 16:12:26 PDT 
Tools/Scripts/svn-apply failed to apply attachment 408603 [details] to trunk.
Please resolve the conflicts and upload a new patch.
Comment 4 Sam Weinig 2020-09-13 10:30:21 PDT 
Created attachment 408654 [details]
Patch
Comment 5 EWS 2020-09-13 11:13:07 PDT 
Committed r266999: <https://trac.webkit.org/changeset/266999>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 408654 [details].
Comment 6 Radar WebKit Bug Importer 2020-09-13 11:14:15 PDT 
<rdar://problem/68808571>