Bug 216335 - Simplify OptionSet::set
Summary: Simplify OptionSet::set
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-09-09 17:39 PDT by Ryosuke Niwa
Modified: 2020-09-09 20:41 PDT (History)
10 users (show)

See Also:

Attachments
Patch (3.13 KB, patch)
2020-09-09 18:10 PDT, Ryosuke Niwa 		sabouhallawa: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2020-09-09 17:39:02 PDT 
In https://trac.webkit.org/r266776, I added OptionSet::set.

Following some discussion in https://bugs.webkit.org/show_bug.cgi?id=216305#c6,
we can see that a simpler variant which uses a branch produces the same assembly in x86_64 and arm64 with -O3.

So just use a simpler code since it's easier to read.
Comment 1 Ryosuke Niwa 2020-09-09 18:10:27 PDT 
Created attachment 408390 [details]
Patch
Comment 2 Said Abou-Hallawa 2020-09-09 19:09:32 PDT 
Comment on attachment 408390 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408390&action=review

> Source/WTF/ChangeLog:3
> +        Simply OptionSet::set

Did you mean to write "Simplify"?
Comment 3 Ryosuke Niwa 2020-09-09 20:24:56 PDT 
(In reply to Said Abou-Hallawa from comment #2)
> Comment on attachment 408390 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=408390&action=review
> 
> > Source/WTF/ChangeLog:3
> > +        Simply OptionSet::set
> 
> Did you mean to write "Simplify"?

Oops, indeed.
Comment 4 Ryosuke Niwa 2020-09-09 20:40:25 PDT 
Committed r266812: <https://trac.webkit.org/changeset/266812>
Comment 5 Radar WebKit Bug Importer 2020-09-09 20:41:29 PDT 
<rdar://problem/68615785>