Bug 216316 - [WebIDL] Split GlobalEventHandlers partial interface mixins out of base mixin
Summary: [WebIDL] Split GlobalEventHandlers partial interface mixins out of base mixin
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-09-09 10:13 PDT by Sam Weinig
Modified: 2020-09-09 15:14 PDT (History)
12 users (show)

See Also:

Attachments
Patch (16.62 KB, patch)
2020-09-09 10:15 PDT, Sam Weinig 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (23.32 KB, patch)
2020-09-09 13:58 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2020-09-09 10:13:47 PDT 
[WebIDL] Split GlobalEventHandlers partial interface mixins out of base mixin
Comment 1 Sam Weinig 2020-09-09 10:15:05 PDT 
Created attachment 408333 [details]
Patch
Comment 2 Darin Adler 2020-09-09 10:31:20 PDT 
Comment on attachment 408333 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408333&action=review

> Source/WebCore/dom/GlobalEventHandlers.idl:96
>  

Remove one more blank line?
Comment 3 Sam Weinig 2020-09-09 11:01:49 PDT 
Going to have to fix those test results too.
Comment 4 Darin Adler 2020-09-09 11:04:27 PDT 
"dom-static-property-for-in-iteration.html"

Is there a specification of what order these properties should be iterated?
Comment 5 Sam Weinig 2020-09-09 13:46:05 PDT 
(In reply to Darin Adler from comment #4)
> "dom-static-property-for-in-iteration.html"
> 
> Is there a specification of what order these properties should be iterated?

It's still an open issue when it comes to mixins and partials - https://github.com/heycam/webidl/issues/432.
Comment 6 Sam Weinig 2020-09-09 13:58:40 PDT 
Created attachment 408365 [details]
Patch
Comment 7 EWS 2020-09-09 15:13:58 PDT 
Committed r266801: <https://trac.webkit.org/changeset/266801>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 408365 [details].
Comment 8 Radar WebKit Bug Importer 2020-09-09 15:14:16 PDT 
<rdar://problem/68598951>