Bug 216272 - [macOS] Date/time inputs should preserve focus on value change
Summary: [macOS] Date/time inputs should preserve focus on value change
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: Safari Technology Preview
Hardware: Mac Unspecified
: P2 Normal
Assignee: Aditya Keerthi
URL:
Keywords: InRadar
Depends on:
Blocks: 216188
  Show dependency tree / graph
 
Reported: 2020-09-08 08:20 PDT by Aditya Keerthi
Modified: 2020-09-08 12:23 PDT (History)
7 users (show)

See Also:

Attachments
Patch (6.73 KB, patch)
2020-09-08 08:51 PDT, Aditya Keerthi 		wenson_hsieh: review+
Details | Formatted Diff | Diff
Patch for landing (6.67 KB, patch)
2020-09-08 09:03 PDT, Aditya Keerthi 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aditya Keerthi 2020-09-08 08:20:06 PDT 
...
Comment 1 Aditya Keerthi 2020-09-08 08:51:40 PDT 
Created attachment 408229 [details]
Patch
Comment 2 Wenson Hsieh 2020-09-08 08:55:14 PDT 
Comment on attachment 408229 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408229&action=review

r=mews!

> LayoutTests/fast/forms/date/date-preserve-focus-value-change.html:4
> +<script src="../../../resources/js-test-pre.js"></script>

Nit - I think in new tests, we prefer to use "js-test.js” instead of -pre/-post.
Comment 3 Aditya Keerthi 2020-09-08 09:03:20 PDT 
Created attachment 408230 [details]
Patch for landing
Comment 4 Aditya Keerthi 2020-09-08 09:04:22 PDT 
(In reply to Wenson Hsieh from comment #2)
> Comment on attachment 408229 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=408229&action=review
> 
> r=mews!
> 
> > LayoutTests/fast/forms/date/date-preserve-focus-value-change.html:4
> > +<script src="../../../resources/js-test-pre.js"></script>
> 
> Nit - I think in new tests, we prefer to use "js-test.js” instead of
> -pre/-post.

Thanks for the review! Updated to use "js-test.js".
Comment 5 EWS 2020-09-08 12:22:54 PDT 
Committed r266739: <https://trac.webkit.org/changeset/266739>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 408230 [details].
Comment 6 Radar WebKit Bug Importer 2020-09-08 12:23:18 PDT 
<rdar://problem/68523398>