Bug 216246 - [WebIDL] Fix issues found by preprocess-idls.pl parser validation and enabled parser validation by default for the tests
Summary: [WebIDL] Fix issues found by preprocess-idls.pl parser validation and enabled...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-09-07 11:24 PDT by Sam Weinig
Modified: 2020-09-07 12:37 PDT (History)
8 users (show)

See Also:

Attachments
Patch (179.32 KB, patch)
2020-09-07 11:47 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2020-09-07 11:24:58 PDT 
[WebIDL] Fix issues found by preprocess-idls.pl parser validation and enabled parser validation by default for the tests
Comment 1 Sam Weinig 2020-09-07 11:47:23 PDT 
Created attachment 408190 [details]
Patch
Comment 2 Darin Adler 2020-09-07 11:53:11 PDT 
Comment on attachment 408190 [details]
Patch

Any effect on compiling the actual WebCore IDL?
Comment 3 Sam Weinig 2020-09-07 12:22:41 PDT 
(In reply to Darin Adler from comment #2)
> Comment on attachment 408190 [details]
> Patch
> 
> Any effect on compiling the actual WebCore IDL?

Nope. I fixed those issues when I introduced the validation but neglected to fix the tests.
Comment 4 EWS 2020-09-07 12:36:57 PDT 
Committed r266709: <https://trac.webkit.org/changeset/266709>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 408190 [details].
Comment 5 Radar WebKit Bug Importer 2020-09-07 12:37:13 PDT 
<rdar://problem/68472234>