Bug 216211 - Remove all non-web-exposed uses of ENABLE(VARIATION_FONTS)
Summary: Remove all non-web-exposed uses of ENABLE(VARIATION_FONTS)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Text (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on: 176215
Blocks:
  Show dependency tree / graph
 
Reported: 2020-09-05 00:50 PDT by Myles C. Maxfield
Modified: 2020-09-06 17:01 PDT (History)
16 users (show)

See Also:

Attachments
Patch (25.59 KB, patch)
2020-09-05 00:51 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (29.48 KB, patch)
2020-09-06 15:24 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2020-09-05 00:50:57 PDT 
Because it's enabled on all Cocoa ports, and we have shipped it for years and don't plan on disabling it, we can just stop consulting with the ENABLE() in Cocoa-specific files.

Also, we can start the process of enabling it for all ports by at least compiling in the internal data structures for it on all ports (but not have any web-exposed behavior change).
Comment 1 Myles C. Maxfield 2020-09-05 00:51:28 PDT 
Created attachment 408070 [details]
Patch
Comment 2 Myles C. Maxfield 2020-09-06 15:24:10 PDT 
Created attachment 408140 [details]
Patch
Comment 3 EWS 2020-09-06 17:00:58 PDT 
Committed r266686: <https://trac.webkit.org/changeset/266686>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 408140 [details].
Comment 4 Radar WebKit Bug Importer 2020-09-06 17:01:17 PDT 
<rdar://problem/68437601>