Bug 216043 - Skip fast/css-custom-paint/out-of-memory-while-adding-worklet-module.html if Gigacage is not enabled
Summary: Skip fast/css-custom-paint/out-of-memory-while-adding-worklet-module.html if ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-09-01 10:15 PDT by Yusuke Suzuki
Modified: 2020-09-02 09:41 PDT (History)
8 users (show)

See Also:

Attachments
Patch (7.01 KB, patch)
2020-09-01 10:22 PDT, Yusuke Suzuki 		mark.lam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2020-09-01 10:15:32 PDT 
Skip fast/css-custom-paint/out-of-memory-while-adding-worklet-module.html if Gigacage is not enabled
Comment 1 Yusuke Suzuki 2020-09-01 10:22:02 PDT 
Created attachment 407692 [details]
Patch
Comment 2 Yusuke Suzuki 2020-09-01 10:22:05 PDT 
<rdar://problem/66394369>
Comment 3 Mark Lam 2020-09-01 10:46:20 PDT 
Comment on attachment 407692 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=407692&action=review

r=me with fix

> Source/JavaScriptCore/tools/JSDollarVM.cpp:3124
> +    return JSValue::encode(jsBoolean(Gigacage::isEnabled()));

Can you add `DollarVMAssertScope assertScope;` before this line?
Comment 4 Yusuke Suzuki 2020-09-01 11:30:37 PDT 
Comment on attachment 407692 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=407692&action=review

Thanks!

>> Source/JavaScriptCore/tools/JSDollarVM.cpp:3124
>> +    return JSValue::encode(jsBoolean(Gigacage::isEnabled()));
> 
> Can you add `DollarVMAssertScope assertScope;` before this line?

Added.
Comment 5 Yusuke Suzuki 2020-09-01 19:18:10 PDT 
Committed r266447: <https://trac.webkit.org/changeset/266447>