Bug 216023 - RenderText::computeCanUseSimplifiedTextMeasuring() seems bogus
Summary: RenderText::computeCanUseSimplifiedTextMeasuring() seems bogus
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-08-31 19:26 PDT by Myles C. Maxfield
Modified: 2020-09-07 19:27 PDT (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2020-08-31 19:26:28 PDT
RenderText::computeCanUseSimplifiedTextMeasuring() has:

    TextRun run(m_text);
    run.setCharacterScanForCodePath(false);
    if (font.codePath(run) != FontCascade::Simple)
        return false;

and FontCascade::codePath() has:

    if (!run.characterScanForCodePath())
        return Simple;

and

bool characterScanForCodePath() const { return m_characterScanForCodePath; }

this code sure looks like:
1. Explicitly set m_characterScanForCodePath to false
2. If m_characterScanForCodePath is false, use the simple text codepath
Comment 1 Radar WebKit Bug Importer 2020-09-07 19:27:12 PDT
<rdar://problem/68482100>