Bug 215995 - Update generateEmptyHeaderAndCpp in generate-bindings.pl to use proper English and use an #error to catch accidental compilation
Summary: Update generateEmptyHeaderAndCpp in generate-bindings.pl to use proper Englis...
Status: RESOLVED CONFIGURATION CHANGED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Bindings (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-08-30 18:25 PDT by Sam Weinig
Modified: 2020-09-14 14:10 PDT (History)
3 users (show)

See Also:

Attachments
Patch (9.56 KB, patch)
2020-08-30 19:15 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2020-08-30 18:25:19 PDT 
As noted by Darin in https://bugs.webkit.org/show_bug.cgi?id=215992, we should update generateEmptyHeaderAndCpp in generate-bindings.pl to use proper English and use an #error to catch accidental compilation.
Comment 1 Sam Weinig 2020-08-30 19:15:38 PDT 
Created attachment 407584 [details]
Patch
Comment 2 Darin Adler 2020-08-31 09:29:19 PDT 
Comment on attachment 407584 [details]
Patch

Looks ike these empty headers and file are indeed compiled, despite the comment saying they "must not".
Comment 3 Sam Weinig 2020-08-31 10:35:53 PDT 
(In reply to Darin Adler from comment #2)
> Comment on attachment 407584 [details]
> Patch
> 
> Looks ike these empty headers and file are indeed compiled, despite the
> comment saying they "must not".

Very much so :).
Comment 4 Radar WebKit Bug Importer 2020-09-06 18:26:18 PDT 
<rdar://problem/68439122>
Comment 5 Sam Weinig 2020-09-14 14:10:35 PDT 
I handled this in another bug.