Bug 215962 - Delete DeprecatedGlobalSettings
Summary: Delete DeprecatedGlobalSettings
Status: REOPENED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords: InRadar
Depends on: 250192
Blocks:
  Show dependency treegraph
 
Reported: 2020-08-28 17:56 PDT by Sam Weinig
Modified: 2023-11-06 02:00 PST (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2020-08-28 17:56:10 PDT
DeprecatedGlobalSettings has been named deprecated for many years. Let's finish it off, and find new homes for its members.
Comment 1 Sam Weinig 2020-09-02 12:36:07 PDT
Most of the very straightforward ones out of the way, now onto the more complicated ones (only listing the getter half of each):


    static bool shouldUseHighResolutionTimers() { return gShouldUseHighResolutionTimers; }

Windows only, used in platform/win/MainThreadSharedTimerWin.cpp (layering violation).


    static bool isAVFoundationEnabled() { return gAVFoundationEnabled; }

Used in platform/graphics/MediaPlayer.cpp (layering violation).


    static bool isAVFoundationNSURLSessionEnabled() { return gAVFoundationNSURLSessionEnabled; }

Used in platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm (layering violation).


    static bool isGStreamerEnabled() { return gGStreamerEnabled; }

Used in platform/graphics/MediaPlayer.cpp (layering violation).


    WEBCORE_EXPORT static bool mockScrollbarsEnabled();

Used in platform/ScrollbarTheme.cpp (layering violation) and testing/InternalSettings.cpp.


    static bool usesOverlayScrollbars();

Used in platform/adwaita/ScrollbarThemeAdwaita.cpp (layering violation), platform/mock/ScrollbarThemeMock.cpp (layering violation), platform/Mac/NSScrollerImpDetails.mm (layering violation) and platform/Mac/ScrollbarThemeMac.mm (layering violation).


    static bool usesMockScrollAnimator();

Used in page/FrameView.cpp, rendering/RenderLayer.cpp, rendering/RenderListBox.cpp. (this one it seems like we could move to Settings.yaml).



    static bool shouldRespectPriorityInCSSAttributeSetters();

Used in css/CSSStyleDeclaration.cpp.


    static bool lowPowerVideoAudioBufferSizeEnabled() { return gLowPowerVideoAudioBufferSizeEnabled; }

Used in platform/audio/cocoa/MediaSessionManagerCocoa.mm (layering violation).


    static bool resourceLoadStatisticsEnabled() { return gResourceLoadStatisticsEnabledEnabled; }

Used in dom/Document.cpp, WebKit/WebProcess/WebProcess.cpp and WebKit/WebProcess/WebPage/WebCookieJar.cpp.


    static unsigned audioSessionCategoryOverride();

Not used anywhere, though setter is, and calls down to AudioSession::sharedSession().setCategoryOverride(...).


    static bool networkDataUsageTrackingEnabled();

Not used anywhere.


    static const String& networkInterfaceName();

Used in WebCore/html/HTMLMediaElement.cpp (this one it seems like we could move to Settings.yaml, probably needs a clearer names, since it is only used for some media related purposes).


    static bool disableScreenSizeOverride() { return gDisableScreenSizeOverride; }

Not used anywhere.


    static bool avKitEnabled() { return gAVKitEnabled; }

Used in WebKit/WebProcess/cocoa/VideoFullscreenManager.mm, WebKitLegacy/mac/WebCoreSupport/WebChromeClient.mm and WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp (layering violation).


    static bool shouldOptOutOfNetworkStateObservation() { return gShouldOptOutOfNetworkStateObservation; }

Used in WebCore/platform/network/iOS/NetworkStateNotifierIOS.mm (layering violation).


    static bool shouldManageAudioSessionCategory() { return gManageAudioSession; }

Used in WebCore/platform/audio/cocoa/MediaSessionManagerCocoa.mm (layering violation), WebCore/platform/mediastream/Mac/BaseAudioSharedUnit.cpp (layering violation), and WebCore/testing/InternalSettings.cpp.


    static bool allowsAnySSLCertificate();

Used in WebCore/platform/network/cf/SocketStreamHandleImplCFNet.cpp (layering violation), WebCore/platform/network/curl/SocketStreamHandleImplCurl.cpp (layering violation) and WebKit/NetworkProcess/soup/NetworkSessionSoup.cpp.
Comment 2 Sam Weinig 2020-09-02 15:35:27 PDT
(In reply to Sam Weinig from comment #1)
> 
> 
>     static bool disableScreenSizeOverride() { return
> gDisableScreenSizeOverride; }
> 
> Not used anywhere.

Actually, this one is indeed still used.
Comment 3 Radar WebKit Bug Importer 2020-09-04 17:57:14 PDT
<rdar://problem/68375087>
Comment 4 Tim Nguyen (:ntim) 2023-11-06 01:58:15 PST

*** This bug has been marked as a duplicate of bug 250192 ***
Comment 5 Tim Nguyen (:ntim) 2023-11-06 02:00:33 PST
Actually we can use this bug to remove the file itself.