Bug 215948 - [ews] Notify bot watchers about pre-existing and flaky test failures for JSC tests
Summary: [ews] Notify bot watchers about pre-existing and flaky test failures for JSC ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-08-28 13:33 PDT by Aakash Jain
Modified: 2020-09-23 11:17 PDT (History)
5 users (show)

See Also:

Attachments
Patch (3.85 KB, patch)
2020-09-04 04:41 PDT, Aakash Jain 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2020-08-28 13:33:59 PDT 
Notify bot watchers about pre-existing and flaky test failures for JSC tests.
Comment 1 Aakash Jain 2020-09-04 04:41:10 PDT 
Created attachment 407958 [details]
Patch
Comment 2 Jonathan Bedard 2020-09-04 11:27:05 PDT 
Comment on attachment 407958 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=407958&action=review

> Tools/BuildSlaveSupport/ews-build/steps.py:1781
> +    def send_email_for_flaky_failure(self, test_name):

Same deal as https://bugs.webkit.org/show_bug.cgi?id=215949, the only variability here seems to be the suite, should we consider basing all of these analysis steps on the same base class?
Comment 3 Aakash Jain 2020-09-04 11:42:16 PDT 
(In reply to Jonathan Bedard from comment #2)
> Same deal as https://bugs.webkit.org/show_bug.cgi?id=215949, the only variability here seems to be the suite, should we consider basing all of these analysis steps on the same base class?
Yeah, will do that in a separate patch.
Comment 4 EWS 2020-09-04 11:51:05 PDT 
commit-queue failed to commit attachment 407958 [details] to WebKit repository.
Comment 5 EWS 2020-09-04 12:19:48 PDT 
Committed r266629: <https://trac.webkit.org/changeset/266629>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 407958 [details].
Comment 6 Radar WebKit Bug Importer 2020-09-04 12:20:16 PDT 
<rdar://problem/68359434>