Bug 215859 - Make ImageDiff before TestWebKitAPI
Summary: Make ImageDiff before TestWebKitAPI
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-08-26 12:35 PDT by Alex Christensen
Modified: 2020-09-02 12:36 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.44 KB, patch)
2020-08-26 12:36 PDT, Alex Christensen 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2020-08-26 12:35:47 PDT 
Make ImageDiff before TestWebKitAPI
Comment 1 Alex Christensen 2020-08-26 12:36:27 PDT 
Created attachment 407322 [details]
Patch
Comment 2 Darin Adler 2020-08-26 14:48:44 PDT 
Comment on attachment 407322 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=407322&action=review

> Tools/ChangeLog:3
> +        Make ImageDiff before TestWebKitAPI

Given you are optimizing the sequence, why did you put it after MiniBrowser?

> Tools/Makefile:5
> +ifeq (,$(DO_NOT_BUILD_IMAGE_DIFF))
> +	MODULES += ImageDiff
> +endif

Would be nice to have a comment here, since it’s not obvious why we are adding ImageDiff to the middle.
Comment 3 Alex Christensen 2020-08-27 09:40:18 PDT 
Comment on attachment 407322 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=407322&action=review

>> Tools/ChangeLog:3
>> +        Make ImageDiff before TestWebKitAPI
> 
> Given you are optimizing the sequence, why did you put it after MiniBrowser?

MiniBrowser doesn't take long to build, but you're right.  That would be even better!
Comment 4 Radar WebKit Bug Importer 2020-09-02 12:36:16 PDT 
<rdar://problem/68226453>