Bug 215689 - [Cocoa] Unify implementation of custom font name aliases between all Cocoa platforms
Summary: [Cocoa] Unify implementation of custom font name aliases between all Cocoa pl...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-08-19 22:35 PDT by Myles C. Maxfield
Modified: 2020-09-05 10:51 PDT (History)
7 users (show)

See Also:

Attachments
Patch (23.36 KB, patch)
2020-08-19 22:37 PDT, Myles C. Maxfield 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2020-08-19 22:35:59 PDT 
[Cocoa] Unify implementation of custom font name aliases between all Cocoa platforms
Comment 1 Myles C. Maxfield 2020-08-19 22:37:11 PDT 
Created attachment 406918 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2020-08-26 22:36:14 PDT 
<rdar://problem/67851826>
Comment 3 Darin Adler 2020-09-05 08:54:11 PDT 
Comment on attachment 406918 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406918&action=review

Nice improvement.

> Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:1311
> +        RetainPtr<CFNumberRef> numberSpacingNumber = adoptCF(CFNumberCreate(kCFAllocatorDefault, kCFNumberIntType, &numberSpacingType));

auto

> Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:1312
> +        RetainPtr<CFNumberRef> monospacedNumbersNumber = adoptCF(CFNumberCreate(kCFAllocatorDefault, kCFNumberIntType, &monospacedNumbersSelector));

auto

> Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:1313
> +        RetainPtr<CTFontDescriptorRef> systemFontDescriptor = adoptCF(CTFontDescriptorCreateForUIType(kCTFontUIFontSystem, size, nullptr));

auto

> Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:1314
> +        RetainPtr<CTFontDescriptorRef> monospaceFontDescriptor = adoptCF(CTFontDescriptorCreateCopyWithFeature(systemFontDescriptor.get(), numberSpacingNumber.get(), monospacedNumbersNumber.get()));

auto
Comment 4 Myles C. Maxfield 2020-09-05 10:51:13 PDT 
Committed r266663: <https://trac.webkit.org/changeset/266663>