Bug 215684 - [Cocoa] USE(PLATFORM_SYSTEM_FALLBACK_LIST) is true on all Cocoa platforms, so there's no need to consult it in Cocoa-specific files
Summary: [Cocoa] USE(PLATFORM_SYSTEM_FALLBACK_LIST) is true on all Cocoa platforms, so...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on:
Blocks: 215685
  Show dependency tree / graph
 
Reported: 2020-08-19 20:22 PDT by Myles C. Maxfield
Modified: 2020-09-05 14:34 PDT (History)
10 users (show)

See Also:

Attachments
Patch (13.17 KB, patch)
2020-08-19 20:29 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (14.37 KB, patch)
2020-08-19 20:31 PDT, Myles C. Maxfield 		darin: review+
Details | Formatted Diff | Diff
Patch for committing (21.15 KB, patch)
2020-09-05 01:19 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch for committing (21.14 KB, patch)
2020-09-05 01:20 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch for committing (21.13 KB, patch)
2020-09-05 01:24 PDT, Myles C. Maxfield 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2020-08-19 20:22:21 PDT 
[Cocoa] USE(PLATFORM_SYSTEM_FALLBACK_LIST) is true on all Cocoa platforms, so there's no need to consult it in Cocoa-specific files
Comment 1 Myles C. Maxfield 2020-08-19 20:29:27 PDT 
Created attachment 406907 [details]
Patch
Comment 2 Myles C. Maxfield 2020-08-19 20:31:21 PDT 
Created attachment 406908 [details]
Patch
Comment 3 Darin Adler 2020-08-19 21:12:08 PDT 
Comment on attachment 406908 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406908&action=review

> Source/WebCore/platform/graphics/FontCascadeDescription.cpp:66
> -#if !USE(PLATFORM_SYSTEM_FALLBACK_LIST)
> +#if !PLATFORM(COCOA)

I feel like any time we change an #if to literally check PLATFORM instead of a feature, it’s a small step backward.
Comment 4 Myles C. Maxfield 2020-08-19 21:48:02 PDT 
Comment on attachment 406908 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406908&action=review

This isn't for any particular bug, so I should probably hold off on committing it.

>> Source/WebCore/platform/graphics/FontCascadeDescription.cpp:66
>> +#if !PLATFORM(COCOA)
> 
> I feel like any time we change an #if to literally check PLATFORM instead of a feature, it’s a small step backward.

Yeah, you're right. It might be better to put copies of this function in each of the port-specific versions of FontCascadeDescription.cpp.
Comment 5 Radar WebKit Bug Importer 2020-08-26 20:23:17 PDT 
<rdar://problem/67847196>
Comment 6 Myles C. Maxfield 2020-09-05 01:19:22 PDT 
Created attachment 408071 [details]
Patch for committing
Comment 7 Myles C. Maxfield 2020-09-05 01:20:15 PDT 
Created attachment 408072 [details]
Patch for committing
Comment 8 Myles C. Maxfield 2020-09-05 01:24:17 PDT 
Created attachment 408073 [details]
Patch for committing
Comment 9 EWS 2020-09-05 11:11:29 PDT 
Tools/Scripts/svn-apply failed to apply attachment 408073 [details] to trunk.
Please resolve the conflicts and upload a new patch.
Comment 10 Myles C. Maxfield 2020-09-05 14:34:22 PDT 
Committed r266672: <https://trac.webkit.org/changeset/266672>