Bug 215628 - [webkitpy] Adopt webkitcorepy's OutputCapture
Summary: [webkitpy] Adopt webkitcorepy's OutputCapture
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-08-18 14:35 PDT by Jonathan Bedard
Modified: 2020-08-19 11:35 PDT (History)
7 users (show)

See Also:

Attachments
Patch (235.14 KB, patch)
2020-08-18 14:41 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2020-08-18 14:35:46 PDT 
Now that OutputCapture has been moved from webkitpy to webkitcorepy, we should remove the one in webkitpy and refactor our testing code so that we use the more modern idioms of the webkitcorepy version of OutputCapture.
Comment 1 Radar WebKit Bug Importer 2020-08-18 14:36:14 PDT 
<rdar://problem/67353710>
Comment 2 Jonathan Bedard 2020-08-18 14:41:10 PDT 
Created attachment 406812 [details]
Patch
Comment 3 Jonathan Bedard 2020-08-18 14:42:53 PDT 
Comment on attachment 406812 [details]
Patch

All about unifying OutputCapture idioms and removing unused code.

There are many individual changes here, but they're all essentially the same thing: use OutputCapture as a decorator, compare stdout/stderr and logs explicitly.
Comment 4 EWS 2020-08-19 11:35:19 PDT 
Committed r265883: <https://trac.webkit.org/changeset/265883>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 406812 [details].