Bug 215615 - WaveShaperNode.curve setter should create a copy of the input array
Summary: WaveShaperNode.curve setter should create a copy of the input array
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Audio (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL: https://www.w3.org/TR/webaudio/#dom-w...
Keywords: InRadar
Depends on:
Blocks: 212611
  Show dependency tree / graph
 
Reported: 2020-08-18 10:31 PDT by Chris Dumez
Modified: 2020-08-18 14:14 PDT (History)
10 users (show)

See Also:

Attachments
Patch (6.77 KB, patch)
2020-08-18 10:34 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (4.95 KB, patch)
2020-08-18 13:14 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2020-08-18 10:31:44 PDT 
WaveShaperNode.curve setter should create a copy of the input array, so that follow-up modifications of the array by the JS do not impact audio processing:
- https://www.w3.org/TR/webaudio/#dom-waveshapernode-curve
Comment 1 Chris Dumez 2020-08-18 10:34:48 PDT 
Created attachment 406792 [details]
Patch
Comment 2 Chris Dumez 2020-08-18 13:14:21 PDT 
Created attachment 406803 [details]
Patch
Comment 3 EWS 2020-08-18 14:13:35 PDT 
Committed r265832: <https://trac.webkit.org/changeset/265832>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 406803 [details].
Comment 4 Radar WebKit Bug Importer 2020-08-18 14:14:17 PDT 
<rdar://problem/67352223>