Bug 215578 - AudioNode.disconnect() does not match the specification
Summary: AudioNode.disconnect() does not match the specification
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Audio (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL: https://www.w3.org/TR/webaudio/#dom-a...
Keywords: InRadar
Depends on:
Blocks: 212611
  Show dependency tree / graph
 
Reported: 2020-08-17 11:32 PDT by Chris Dumez
Modified: 2020-08-17 16:14 PDT (History)
12 users (show)

See Also:

Attachments
Patch (21.21 KB, patch)
2020-08-17 13:04 PDT, Chris Dumez 		eric.carlson: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2020-08-17 11:32:52 PDT 
AudioNode.disconnect() does not match the specification. There are a lot of overloads in the specification that we do not support.
Comment 1 Chris Dumez 2020-08-17 13:04:41 PDT 
Created attachment 406739 [details]
Patch
Comment 2 Eric Carlson 2020-08-17 13:12:54 PDT 
Comment on attachment 406739 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406739&action=review

> Source/WebCore/ChangeLog:9
> +        AudioNode.disconnect() did not match the specification. There were a lot of overloads in
> +        the specification that we do not support:

There is a minor tense problem here, should either be "There were ... that we did not..." or "There are ... that we do not ..."
Comment 3 Chris Dumez 2020-08-17 16:13:17 PDT 
Committed r265781: <https://trac.webkit.org/changeset/265781>
Comment 4 Radar WebKit Bug Importer 2020-08-17 16:14:34 PDT 
<rdar://problem/67278263>