Bug 215420 - Clean up the VideoFullscreenModelClient management in VideoFullscreenModelContext
Summary: Clean up the VideoFullscreenModelClient management in VideoFullscreenModelCon...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Peng Liu
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-08-12 11:37 PDT by Peng Liu
Modified: 2020-08-19 11:37 PDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Peng Liu 2020-08-12 11:37:02 PDT 
We should replace `HashSet<WebCore::VideoFullscreenModelClient*>` with `WeakHashSet<WebCore::VideoFullscreenModelClient>` and update all the call sites. This may be a source of latent bugs, if the m_clients set is mutated while calling callbacks.
https://bugs.webkit.org/show_bug.cgi?id=215305#c8
Comment 1 Radar WebKit Bug Importer 2020-08-19 11:37:13 PDT 
<rdar://problem/67415826>