215358 – Consider changing ScriptExecutable::prepareForExecution() to return a CodeBlock*.

Bug 215358 - Consider changing ScriptExecutable::prepareForExecution() to return a CodeBlock*.

Summary: Consider changing ScriptExecutable::prepareForExecution() to return a CodeBlo...

Status:	ASSIGNED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	JavaScriptCore (show other bugs)
Version:	WebKit Nightly Build
Hardware:	Unspecified Unspecified

Importance:	P2 Normal
Assignee:	Mark Lam

URL:
Keywords:	InRadar

Depends on:
Blocks:

Reported:	2020-08-10 22:44 PDT by Mark Lam
Modified:	2020-08-17 22:45 PDT (History)
CC List:	6 users (show)

See Also:	215357

Attachments
proposed patch. (3.76 KB, patch) 2020-08-10 22:55 PDT, Mark Lam	no flags	Details \| Formatted Diff \| Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Mark Lam 2020-08-10 22:44:23 PDT

There's no need to return an Exception*.  The canonical way to get the Exception* is from a ThrowScope.

This non-canonical idiom of returning an Exception* here can result in bugs e.g. https://bugs.webkit.org/show_bug.cgi?id=215357.

Comment 1 Mark Lam 2020-08-10 22:55:58 PDT Comment hidden (obsolete)

Created attachment 406362 [details]
proposed patch.

Comment 2 Mark Lam 2020-08-10 23:00:12 PDT Comment hidden (obsolete)

Comment on attachment 406362 [details]
proposed patch.

Submitted patch to wrong bug.  Sorry.

Comment 3 Radar WebKit Bug Importer 2020-08-17 22:45:14 PDT

<rdar://problem/67298086>