Bug 215332 - MobileSafari crashes at WebCore: -[WebAVPlayerController seekToTime:toleranceBefore:toleranceAfter:]
Summary: MobileSafari crashes at WebCore: -[WebAVPlayerController seekToTime:tolerance...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Peng Liu
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-08-10 12:58 PDT by Peng Liu
Modified: 2020-08-10 15:17 PDT (History)
3 users (show)

See Also:


Attachments
Patch (1.52 KB, patch)
2020-08-10 13:01 PDT, Peng Liu
eric.carlson: review+
Details | Formatted Diff | Diff
Patch for landing (1.51 KB, patch)
2020-08-10 13:34 PDT, Peng Liu
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Peng Liu 2020-08-10 12:58:40 PDT
MobileSafari crashes at WebCore: -[WebAVPlayerController seekToTime:toleranceBefore:toleranceAfter:]
Comment 1 Peng Liu 2020-08-10 12:59:38 PDT
<rdar://problem/66310231>
Comment 2 Peng Liu 2020-08-10 13:01:55 PDT
Created attachment 406321 [details]
Patch
Comment 3 Eric Carlson 2020-08-10 13:21:06 PDT
Comment on attachment 406321 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406321&action=review

> Source/WebCore/ChangeLog:8
> +        Add a NULL pointer checking to fix a crash.

s/checking/check/
Comment 4 Peng Liu 2020-08-10 13:34:24 PDT
Created attachment 406324 [details]
Patch for landing
Comment 5 Peng Liu 2020-08-10 13:34:43 PDT
Comment on attachment 406321 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406321&action=review

>> Source/WebCore/ChangeLog:8
>> +        Add a NULL pointer checking to fix a crash.
> 
> s/checking/check/

Fixed.
Comment 6 EWS 2020-08-10 15:17:55 PDT
Committed r265457: <https://trac.webkit.org/changeset/265457>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 406324 [details].