Bug 215286 - DFG should always run CFG Simplification after Constant Folding.
Summary: DFG should always run CFG Simplification after Constant Folding.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Miller
URL:
Keywords: InRadar
: 148260 (view as bug list)
Depends on:
Blocks:
 
Reported: 2020-08-07 11:59 PDT by Keith Miller
Modified: 2020-08-24 21:32 PDT (History)
8 users (show)

See Also:

Attachments
Patch (4.43 KB, patch)
2020-08-07 12:07 PDT, Keith Miller 		no flags Details | Formatted Diff | Diff
Patch (4.64 KB, patch)
2020-08-10 10:37 PDT, Keith Miller 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Miller 2020-08-07 11:59:53 PDT 
DFG should always run CFG Simplification after Constant Folding.
Comment 1 Keith Miller 2020-08-07 12:07:37 PDT 
Created attachment 406199 [details]
Patch
Comment 2 Robin Morisset 2020-08-10 00:24:40 PDT 
Comment on attachment 406199 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406199&action=review

> Source/JavaScriptCore/dfg/DFGCFGSimplificationPhase.cpp:-52
> -        // FIXME: We should make this work in SSA. https://bugs.webkit.org/show_bug.cgi?id=148260

If this is no longer a FIXME, please close the corresponding bug on bugzilla.

> Source/JavaScriptCore/dfg/DFGValidate.cpp:-814
> -            bool didSeeExitOK = false;

Why did you remove this validation? Can you explain it in the Changelog if it is on purpose?
Comment 3 Keith Miller 2020-08-10 09:54:18 PDT 
*** Bug 148260 has been marked as a duplicate of this bug. ***
Comment 4 Keith Miller 2020-08-10 09:56:18 PDT 
Comment on attachment 406199 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406199&action=review

>> Source/JavaScriptCore/dfg/DFGCFGSimplificationPhase.cpp:-52
>> -        // FIXME: We should make this work in SSA. https://bugs.webkit.org/show_bug.cgi?id=148260
> 
> If this is no longer a FIXME, please close the corresponding bug on bugzilla.

Done.

>> Source/JavaScriptCore/dfg/DFGValidate.cpp:-814
>> -            bool didSeeExitOK = false;
> 
> Why did you remove this validation? Can you explain it in the Changelog if it is on purpose?

Because it's unnecessary and fails when you merge two blocks where the latter block has a Phi. I'll add a comment to the ChangeLog.
Comment 5 Keith Miller 2020-08-10 10:37:35 PDT 
Created attachment 406310 [details]
Patch
Comment 6 Radar WebKit Bug Importer 2020-08-14 12:00:21 PDT 
<rdar://problem/67087402>
Comment 7 EWS 2020-08-24 21:32:17 PDT 
Committed r266101: <https://trac.webkit.org/changeset/266101>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 406310 [details].