Bug 215272 - Fix inequality in newly added assertion
Summary: Fix inequality in newly added assertion
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Robin Morisset
URL:
Keywords: InRadar
Depends on: 215100
Blocks:
  Show dependency tree / graph
 
Reported: 2020-08-07 08:55 PDT by Robin Morisset
Modified: 2020-08-07 09:41 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.30 KB, patch)
2020-08-07 08:57 PDT, Robin Morisset 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Robin Morisset 2020-08-07 08:55:15 PDT 
In IndexSparseSet::validate() (that I just added), there is an assertion that m_values.size() < m_map.size().
It should be <= instead.
Comment 1 Robin Morisset 2020-08-07 08:57:10 PDT 
Created attachment 406177 [details]
Patch
Comment 2 EWS 2020-08-07 09:39:35 PDT 
Committed r265378: <https://trac.webkit.org/changeset/265378>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 406177 [details].
Comment 3 Radar WebKit Bug Importer 2020-08-07 09:40:22 PDT 
<rdar://problem/66685769>
Comment 4 Alexey Proskuryakov 2020-08-07 09:41:57 PDT 
Comment on attachment 406177 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406177&action=review

> Source/WTF/ChangeLog:8
> +        No new tests, as it was caught by our testing infrastructure (not sure why it only got caught after landing).

As determined in a Slack discussion, the explanation is that the landed patch was different from what went through EWS.