Bug 215262 - [GStreamer] gst-full standalone library support
Summary: [GStreamer] gst-full standalone library support
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Philippe Normand
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-08-07 02:11 PDT by Philippe Normand
Modified: 2020-08-11 01:18 PDT (History)
17 users (show)

See Also:


Attachments
Patch (32.95 KB, patch)
2020-08-07 04:54 PDT, Philippe Normand
no flags Details | Formatted Diff | Diff
Patch (32.94 KB, patch)
2020-08-07 04:56 PDT, Philippe Normand
calvaris: review+
calvaris: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2020-08-07 02:11:31 PDT
In some deployment cases it might be convenient to rely on the gst-full library which bundles the GStreamer libraries and plugins in a single shared library.
Comment 1 Philippe Normand 2020-08-07 04:54:08 PDT
Created attachment 406162 [details]
Patch
Comment 2 EWS Watchlist 2020-08-07 04:54:53 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Philippe Normand 2020-08-07 04:56:59 PDT
Created attachment 406163 [details]
Patch
Comment 4 Xabier Rodríguez Calvar 2020-08-10 08:20:09 PDT
Comment on attachment 406163 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406163&action=review

> Source/WebKit/UIProcess/gstreamer/WebPageProxyGStreamer.cpp:45
> +#if !USE(GSTREAMER_FULL)
>      auto request = InstallMissingMediaPluginsPermissionRequest::create(*this, details, description);
>      if (pageClient().decidePolicyForInstallMissingMediaPluginsPermissionRequest(request.get()))
>          return;
>  
>      request->deny();
> +#endif

#else
UNUSED_PARAM...

> Tools/ChangeLog:8
> +        Disable GStreamer options command-line support in MiniBrowsers. This isn't very useful and

State that this is a non-related clean-up or move it to a different patch, please.
Comment 5 Philippe Normand 2020-08-11 01:17:45 PDT
Committed r265492: <https://trac.webkit.org/changeset/265492>
Comment 6 Radar WebKit Bug Importer 2020-08-11 01:18:21 PDT
<rdar://problem/66824560>