Bug 215196 - Change the system version prefixes to match macOS version numbers
Summary: Change the system version prefixes to match macOS version numbers
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: Other
Hardware: Mac Other
: P2 Trivial
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-08-05 15:34 PDT by Remy Demarest
Modified: 2020-08-06 12:36 PDT (History)
11 users (show)

See Also:

Attachments
Patch (7.56 KB, patch)
2020-08-05 15:34 PDT, Remy Demarest 		no flags Details | Formatted Diff | Diff
Corrected patch including ChangeLogs (13.87 KB, patch)
2020-08-05 17:38 PDT, Remy Demarest 		no flags Details | Formatted Diff | Diff
Patch with style fixes (14.55 KB, patch)
2020-08-06 10:52 PDT, Remy Demarest 		ap: review-
ap: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Remy Demarest 2020-08-05 15:34:08 PDT 
Created attachment 406052 [details]
Patch

<rdar://problem/66596776>
Comment 1 EWS Watchlist 2020-08-05 15:35:12 PDT 
Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE
Comment 2 Remy Demarest 2020-08-05 17:38:05 PDT 
Created attachment 406061 [details]
Corrected patch including ChangeLogs
Comment 3 Remy Demarest 2020-08-06 10:52:43 PDT 
Created attachment 406092 [details]
Patch with style fixes
Comment 4 Alexey Proskuryakov 2020-08-06 11:47:30 PDT 
Comment on attachment 406092 [details]
Patch with style fixes

This patch doesn't apply, it conflicts with recent removal of 10.16 code.

No opinion on the substance of the patch (not obvious to me that it's desirable, but that's because I don't know how SYSTEM_VERSION_PREFIX is used).
Comment 5 Remy Demarest 2020-08-06 11:55:23 PDT 
Where can I see the conflicts it creates?
Comment 6 Remy Demarest 2020-08-06 12:35:39 PDT 
There is a hard limit on the length of the major version of the framework that we link to WebKit. I'm rescinding this change and bug.
Comment 7 Remy Demarest 2020-08-06 12:36:14 PDT 
Marking as NTBF.