Bug 215142 - REGRESSION(r265167): media/media-source/media-source-webm.html failing
Summary: REGRESSION(r265167): media/media-source/media-source-webm.html failing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-08-04 14:54 PDT by Jer Noble
Modified: 2020-08-05 15:04 PDT (History)
8 users (show)

See Also:

Attachments
Patch (5.30 KB, patch)
2020-08-04 15:03 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch for landing (5.27 KB, patch)
2020-08-04 18:16 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2020-08-04 14:54:23 PDT 
REGRESSION(r265167): media/media-source/media-source-webm.html failing
Comment 1 Jer Noble 2020-08-04 14:58:55 PDT 
<rdar://problem/66487888>
Comment 2 Jer Noble 2020-08-04 15:03:18 PDT 
Created attachment 405949 [details]
Patch
Comment 3 Eric Carlson 2020-08-04 15:29:31 PDT 
Comment on attachment 405949 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405949&action=review

> LayoutTests/media/media-source/media-source-webm.html:22
> +                // First resize can be 0x0 (Mac) or 640x480 (GTK+)

is `or 640x480 (GTK+)` helpful?
Comment 4 Jer Noble 2020-08-04 18:15:12 PDT 
(In reply to Eric Carlson from comment #3)
> Comment on attachment 405949 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=405949&action=review
> 
> > LayoutTests/media/media-source/media-source-webm.html:22
> > +                // First resize can be 0x0 (Mac) or 640x480 (GTK+)
> 
> is `or 640x480 (GTK+)` helpful?

Probably not. :)
Comment 5 Jer Noble 2020-08-04 18:16:13 PDT 
Created attachment 405974 [details]
Patch for landing
Comment 6 EWS 2020-08-04 18:42:01 PDT 
Committed r265273: <https://trac.webkit.org/changeset/265273>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 405974 [details].