Bug 215140 - Web Inspector: Clicking on sortable Table headers should expand vertical borders
Summary: Web Inspector: Clicking on sortable Table headers should expand vertical borders
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nikita Vasilyev
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-08-04 14:45 PDT by Nikita Vasilyev
Modified: 2020-08-11 11:13 PDT (History)
3 users (show)

See Also:

Attachments
[Video] macOS table header divider height (307.99 KB, video/quicktime)
2020-08-04 14:45 PDT, Nikita Vasilyev 		no flags Details
Patch (for prosperity) (4.63 KB, patch)
2020-08-10 19:43 PDT, Nikita Vasilyev 		nvasilyev: review-
nvasilyev: commit-queue-
Details | Formatted Diff | Diff
Patch (1.32 KB, patch)
2020-08-10 19:49 PDT, Nikita Vasilyev 		no flags Details | Formatted Diff | Diff
[Video] With patch applied (1.10 MB, video/quicktime)
2020-08-10 19:49 PDT, Nikita Vasilyev 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nikita Vasilyev 2020-08-04 14:45:47 PDT 
Created attachment 405944 [details]
[Video] macOS table header divider height

On macOS Catalina and Big Sur, clicking on the header should expand the height of vertical dividers.
Comment 1 Nikita Vasilyev 2020-08-10 19:43:06 PDT 
Created attachment 406353 [details]
Patch (for prosperity)

In this patch I attempted to resolve the issue in both Table and DataGrid.  I didn't fix it in DataGrid completely (there's an edge case with hidden columns).

I'm going to abandon this because DataGrid is being phased out in favor of Table.
Comment 2 Nikita Vasilyev 2020-08-10 19:49:09 PDT 
Created attachment 406354 [details]
Patch
Comment 3 Nikita Vasilyev 2020-08-10 19:49:44 PDT 
Created attachment 406355 [details]
[Video] With patch applied
Comment 4 Devin Rousso 2020-08-11 11:09:55 PDT 
Comment on attachment 406354 [details]
Patch

r=me, nice fix :)
Comment 5 EWS 2020-08-11 11:12:35 PDT 
Committed r265507: <https://trac.webkit.org/changeset/265507>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 406354 [details].
Comment 6 Radar WebKit Bug Importer 2020-08-11 11:13:18 PDT 
<rdar://problem/66850270>